diff options
| author |   Hangbin Liu <liuhangbin@gmail.com> | 2018-08-14 17:28:26 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-08-16 12:08:26 -0700 |
| commit | a51c76b4dfb30496dc65396a957ef0f06af7fb22 (patch) | |
| tree | 46091d92dcb6fa4e47dade2c071e88932dc5126b /net/sched/cls_matchall.c | |
| parent | Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal (diff) | |
| download | linux-dev-a51c76b4dfb30496dc65396a957ef0f06af7fb22.tar.xz linux-dev-a51c76b4dfb30496dc65396a957ef0f06af7fb22.zip | |
cls_matchall: fix tcf_unbind_filter missing
Fix tcf_unbind_filter missing in cls_matchall as this will trigger
WARN_ON() in cbq_destroy_class().
Fixes: fd62d9f5c575f ("net/sched: matchall: Fix configuration race")
Reported-by: Li Shuang <shuali@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_matchall.c')
| -rw-r--r-- | net/sched/cls_matchall.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c index af16f36ed578..856fa79d4ffd 100644 --- a/net/sched/cls_matchall.c +++ b/net/sched/cls_matchall.c @@ -113,6 +113,8 @@ static void mall_destroy(struct tcf_proto *tp, struct netlink_ext_ack *extack) if (!head) return; + tcf_unbind_filter(tp, &head->res); + if (!tc_skip_hw(head->flags)) mall_destroy_hw_filter(tp, head, (unsigned long) head, extack); |