diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-05-01 11:23:15 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-05-04 00:46:27 -0400 |
| commit | e512fcf0280ae037e2e99476bd59c726c4b44309 (patch) | |
| tree | 07cef2c1b90085c8bb01f7923e034c6e0c90f787 /net/sched/cls_u32.c | |
| parent | net: add a generic tracepoint for TX queue timeout (diff) | |
| download | linux-dev-e512fcf0280ae037e2e99476bd59c726c4b44309.tar.xz linux-dev-e512fcf0280ae037e2e99476bd59c726c4b44309.zip | |
net: sched: cls_u32: use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.
So, replace code of the following form:
sizeof(*s) + s->nkeys*sizeof(struct tc_u32_key)
with:
struct_size(s, keys, s->nkeys)
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/sched/cls_u32.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 04e9ef088535..4b8710a266cc 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -847,7 +847,7 @@ static struct tc_u_knode *u32_init_knode(struct net *net, struct tcf_proto *tp, /* Similarly success statistics must be moved as pointers */ new->pcpu_success = n->pcpu_success; #endif - memcpy(&new->sel, s, sizeof(*s) + s->nkeys*sizeof(struct tc_u32_key)); + memcpy(&new->sel, s, struct_size(s, keys, s->nkeys)); if (tcf_exts_init(&new->exts, net, TCA_U32_ACT, TCA_U32_POLICE)) { kfree(new); |