aboutsummaryrefslogtreecommitdiffstats
path: root/net/sched/sch_blackhole.c
diff options
context:
space:
mode:
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>2018-06-15 13:27:31 +0300
committerDavid S. Miller <davem@davemloft.net>2018-06-17 08:42:33 +0900
commit7e85dc8cb35abf16455f1511f0670b57c1a84608 (patch)
tree67373c29f348071727ab51c76c30b3ae886e4045 /net/sched/sch_blackhole.c
parentbluetooth: hci_nokia: Don't include linux/unaligned/le_struct.h directly. (diff)
downloadlinux-dev-7e85dc8cb35abf16455f1511f0670b57c1a84608.tar.xz
linux-dev-7e85dc8cb35abf16455f1511f0670b57c1a84608.zip
net_sched: blackhole: tell upper qdisc about dropped packets
When blackhole is used on top of classful qdisc like hfsc it breaks qlen and backlog counters because packets are disappear without notice. In HFSC non-zero qlen while all classes are inactive triggers warning: WARNING: ... at net/sched/sch_hfsc.c:1393 hfsc_dequeue+0xba4/0xe90 [sch_hfsc] and schedules watchdog work endlessly. This patch return __NET_XMIT_BYPASS in addition to NET_XMIT_SUCCESS, this flag tells upper layer: this packet is gone and isn't queued. Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_blackhole.c')
-rw-r--r--net/sched/sch_blackhole.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/sch_blackhole.c b/net/sched/sch_blackhole.c
index c98a61e980ba..9c4c2bb547d7 100644
--- a/net/sched/sch_blackhole.c
+++ b/net/sched/sch_blackhole.c
@@ -21,7 +21,7 @@ static int blackhole_enqueue(struct sk_buff *skb, struct Qdisc *sch,
struct sk_buff **to_free)
{
qdisc_drop(skb, sch, to_free);
- return NET_XMIT_SUCCESS;
+ return NET_XMIT_SUCCESS | __NET_XMIT_BYPASS;
}
static struct sk_buff *blackhole_dequeue(struct Qdisc *sch)