diff options
| author |   Eric Dumazet <edumazet@google.com> | 2016-06-10 16:41:39 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-06-10 23:58:21 -0700 |
| commit | 45f50bed1d808794e514e9eed0e579a8756ce2ba (patch) | |
| tree | 05d9f30419d6a5ef9b503487661959ef29c2fec5 /net/sched/sch_fq.c | |
| parent | net_sched: netem: remove qdisc_is_throttled() use (diff) | |
| download | linux-dev-45f50bed1d808794e514e9eed0e579a8756ce2ba.tar.xz linux-dev-45f50bed1d808794e514e9eed0e579a8756ce2ba.zip | |
net_sched: remove generic throttled management
__QDISC_STATE_THROTTLED bit manipulation is rather expensive
for HTB and few others.
I already removed it for sch_fq in commit f2600cf02b5b
("net: sched: avoid costly atomic operation in fq_dequeue()")
and so far nobody complained.
When one ore more packets are stuck in one or more throttled
HTB class, a htb dequeue() performs two atomic operations
to clear/set __QDISC_STATE_THROTTLED bit, while root qdisc
lock is held.
Removing this pair of atomic operations bring me a 8 % performance
increase on 200 TCP_RR tests, in presence of throttled classes.
This patch has no side effect, since nothing actually uses
disc_is_throttled() anymore.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/sched/sch_fq.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c index 3c6a47d66a04..f49c81e91acd 100644 --- a/net/sched/sch_fq.c +++ b/net/sched/sch_fq.c @@ -445,8 +445,7 @@ begin: if (!head->first) { if (q->time_next_delayed_flow != ~0ULL) qdisc_watchdog_schedule_ns(&q->watchdog, - q->time_next_delayed_flow, - false); + q->time_next_delayed_flow); return NULL; } } |