aboutsummaryrefslogtreecommitdiffstats
path: root/net/sched/sch_tbf.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2022-08-29 13:02:27 +0100
committerDavid S. Miller <davem@davemloft.net>2022-08-29 13:02:27 +0100
commitcb10b0f91c5f76de981ef927e7dadec60c5a5d96 (patch)
treefd0bbea44ebff1928f93194f3cd6eb40d3bab4a1 /net/sched/sch_tbf.c
parentr8152: add PID for the Lenovo OneLink+ Dock (diff)
parentnet: Use u64_stats_fetch_begin_irq() for stats fetch. (diff)
downloadlinux-dev-cb10b0f91c5f76de981ef927e7dadec60c5a5d96.tar.xz
linux-dev-cb10b0f91c5f76de981ef927e7dadec60c5a5d96.zip
Merge branch 'u64_stats-fixups'
Sebastian Andrzej Siewior says: ==================== net: u64_stats fixups for 32bit. while looking at the u64-stats patch https://lore.kernel.org/all/20220817162703.728679-10-bigeasy@linutronix.de I noticed that u64_stats_fetch_begin() is used. That suspicious thing about it is that network processing, including stats update, is performed in NAPI and so I would expect to see u64_stats_fetch_begin_irq() in order to avoid updates from NAPI during the read. This is only needed on 32bit-UP where the seqcount is not used. This is address in 2/2. The remaining user take some kind of precaution and may use u64_stats_fetch_begin(). I updated the previously mentioned patch to get rid of u64_stats_fetch_begin_irq(). If this is not considered stable patch worthy then it can be ignored and considred fixed by the other series which removes the special 32bit cases. The xrs700x driver reads and writes the counter from preemptible context so the only missing piece here is at least disable preemption on the writer side to avoid preemption while the writer is in progress. The possible reader would spin then until the writer completes its write critical section which is considered bad. This is addressed in 1/2 by using u64_stats_update_begin_irqsave() and so disable interrupts during the write critical section. The other closet resemblance I found is mdio_bus.c::mdiobus_stats_acct() where preemtion is disabled unconditionally. This is something I want to avoid since it also affects 64bit. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions