diff options
| author |   Eric Dumazet <edumazet@google.com> | 2019-10-23 22:44:50 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-28 13:33:41 -0700 |
| commit | 3ef7cf57c72f32f61e97f8fa401bc39ea1f1a5d4 (patch) | |
| tree | 7f962942a142ed611e6c063171ef0092f8af8fd8 /net/sctp | |
| parent | udp: use skb_queue_empty_lockless() (diff) | |
| download | linux-dev-3ef7cf57c72f32f61e97f8fa401bc39ea1f1a5d4.tar.xz linux-dev-3ef7cf57c72f32f61e97f8fa401bc39ea1f1a5d4.zip | |
net: use skb_queue_empty_lockless() in poll() handlers
Many poll() handlers are lockless. Using skb_queue_empty_lockless()
instead of skb_queue_empty() is more appropriate.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/sctp/socket.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 5ca0ec0e823c..cfb25391b8b0 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -8476,7 +8476,7 @@ __poll_t sctp_poll(struct file *file, struct socket *sock, poll_table *wait) mask = 0; /* Is there any exceptional events? */ - if (sk->sk_err || !skb_queue_empty(&sk->sk_error_queue)) + if (sk->sk_err || !skb_queue_empty_lockless(&sk->sk_error_queue)) mask |= EPOLLERR | (sock_flag(sk, SOCK_SELECT_ERR_QUEUE) ? EPOLLPRI : 0); if (sk->sk_shutdown & RCV_SHUTDOWN) @@ -8485,7 +8485,7 @@ __poll_t sctp_poll(struct file *file, struct socket *sock, poll_table *wait) mask |= EPOLLHUP; /* Is it readable? Reconsider this code with TCP-style support. */ - if (!skb_queue_empty(&sk->sk_receive_queue)) + if (!skb_queue_empty_lockless(&sk->sk_receive_queue)) mask |= EPOLLIN | EPOLLRDNORM; /* The association is either gone or not ready. */ |