diff options
| author |   Ursula Braun <ubraun@linux.ibm.com> | 2019-01-30 18:51:00 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-02-01 14:45:44 -0800 |
| commit | 14d22d4d61e40623a7c5816728bfe55c322e779a (patch) | |
| tree | 7199bee627e5b513827cd57add8cb0edbc37048c /net/smc | |
| parent | enic: fix checksum validation for IPv6 (diff) | |
| download | linux-dev-14d22d4d61e40623a7c5816728bfe55c322e779a.tar.xz linux-dev-14d22d4d61e40623a7c5816728bfe55c322e779a.zip | |
net/smc: fix another sizeof to int comparison
Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result. kernel_sendmsg can return a negative
error code.
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc')
| -rw-r--r-- | net/smc/smc_clc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c index 776e9dfc915d..d53fd588d1f5 100644 --- a/net/smc/smc_clc.c +++ b/net/smc/smc_clc.c @@ -378,7 +378,7 @@ int smc_clc_send_decline(struct smc_sock *smc, u32 peer_diag_info) vec.iov_len = sizeof(struct smc_clc_msg_decline); len = kernel_sendmsg(smc->clcsock, &msg, &vec, 1, sizeof(struct smc_clc_msg_decline)); - if (len < sizeof(struct smc_clc_msg_decline)) + if (len < 0 || len < sizeof(struct smc_clc_msg_decline)) len = -EPROTO; return len > 0 ? 0 : len; } |