diff options
| author |   Kangjie Lu <kjlu@umn.edu> | 2019-03-15 12:11:59 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-16 12:09:05 -0700 |
| commit | 4589e28db46ee4961edfd794c5bb43887d38c8e5 (patch) | |
| tree | 68b9946a8bf4651fa74a47f29a6551b6a70a0ef6 /net/tipc/group.c | |
| parent | net: ncsi: fix a missing check for nla_nest_start (diff) | |
| download | linux-dev-4589e28db46ee4961edfd794c5bb43887d38c8e5.tar.xz linux-dev-4589e28db46ee4961edfd794c5bb43887d38c8e5.zip | |
net: tipc: fix a missing check of nla_nest_start
nla_nest_start could fail and requires a check. The fix returns
-EMSGSIZE if it fails.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/group.c')
| -rw-r--r-- | net/tipc/group.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/tipc/group.c b/net/tipc/group.c index 06fee142f09f..63f39201e41e 100644 --- a/net/tipc/group.c +++ b/net/tipc/group.c @@ -919,6 +919,9 @@ int tipc_group_fill_sock_diag(struct tipc_group *grp, struct sk_buff *skb) { struct nlattr *group = nla_nest_start(skb, TIPC_NLA_SOCK_GROUP); + if (!group) + return -EMSGSIZE; + if (nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_ID, grp->type) || nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_INSTANCE, |