diff options
| author |   Jon Maloy <jon.maloy@ericsson.com> | 2018-02-26 20:14:04 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-02-27 11:46:03 -0500 |
| commit | 1b22bcad7e397252ecc9a8c471334f70b46820fc (patch) | |
| tree | a89ec297430075d8a6a90ac6aa088d7b15744642 /net/tipc/socket.c | |
| parent | devlink: Fix resource coverity errors (diff) | |
| download | linux-dev-1b22bcad7e397252ecc9a8c471334f70b46820fc.tar.xz linux-dev-1b22bcad7e397252ecc9a8c471334f70b46820fc.zip | |
tipc: correct initial value for group congestion flag
In commit 60c253069632 ("tipc: fix race between poll() and
setsockopt()") we introduced a pointer from struct tipc_group to the
'group_is_connected' flag in struct tipc_sock, so that this field can
be checked without dereferencing the group pointer of the latter struct.
The initial value for this flag is correctly set to 'false' when a
group is created, but we miss the case when no group is created at
all, in which case the initial value should be 'true'. This has the
effect that SOCK_RDM/DGRAM sockets sending datagrams never receive
POLLOUT if they request so.
This commit corrects this bug.
Fixes: 60c253069632 ("tipc: fix race between poll() and setsockopt()")
Reported-by: Hoang Le <hoang.h.le@dektek.com.au>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/socket.c')
| -rw-r--r-- | net/tipc/socket.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index b0323ec7971e..7dfa9fc99ec3 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -473,6 +473,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock, sk->sk_write_space = tipc_write_space; sk->sk_destruct = tipc_sock_destruct; tsk->conn_timeout = CONN_TIMEOUT_DEFAULT; + tsk->group_is_open = true; atomic_set(&tsk->dupl_rcvcnt, 0); /* Start out with safe limits until we receive an advertised window */ |