diff options
| author |   andrew hendry <andrew.hendry@gmail.com> | 2009-11-24 15:16:05 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-11-29 00:25:02 -0800 |
| commit | 429d33ace5ce6122817f8abe9d170eaa55dc3af9 (patch) | |
| tree | 6fff27906c529427ae1a7b180450c148a093623b /net/x25/x25_route.c | |
| parent | X25: Check for errors in x25_init (diff) | |
| download | linux-dev-429d33ace5ce6122817f8abe9d170eaa55dc3af9.tar.xz linux-dev-429d33ace5ce6122817f8abe9d170eaa55dc3af9.zip | |
X25: Fix oops and refcnt problems from x25_dev_get
Calls to x25_dev_get check for dev = NULL which was not set.
It allowed x25 to set routes and ioctls on down interfaces.
This caused oopses and refcnt problems on device_unregister.
Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/x25/x25_route.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/x25/x25_route.c b/net/x25/x25_route.c index 66961ea28c91..b95fae9ab393 100644 --- a/net/x25/x25_route.c +++ b/net/x25/x25_route.c @@ -136,8 +136,10 @@ struct net_device *x25_dev_get(char *devname) #if defined(CONFIG_LLC) || defined(CONFIG_LLC_MODULE) && dev->type != ARPHRD_ETHER #endif - ))) + ))){ dev_put(dev); + dev = NULL; + } return dev; } |