diff options
| author |   Michal Miroslaw <mirq-linux@rere.qmqm.pl> | 2007-03-04 15:58:40 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@sunset.davemloft.net> | 2007-03-05 13:25:22 -0800 |
| commit | 05f7b7b369e039458a77768619dde123d868c78d (patch) | |
| tree | 571a056e23ef46bdfadddefad08bd1138a58046a /net | |
| parent | [NETFILTER]: nfnetlink_log: fix reference leak (diff) | |
| download | linux-dev-05f7b7b369e039458a77768619dde123d868c78d.tar.xz linux-dev-05f7b7b369e039458a77768619dde123d868c78d.zip | |
[NETFILTER]: nfnetlink_log: fix use after free
Paranoia: instance_put() might have freed the inst pointer when we
spin_unlock_bh().
Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nfnetlink_log.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 62c3f31cdb97..27b844a67ec1 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -393,8 +393,8 @@ static void nfulnl_timer(unsigned long data) spin_lock_bh(&inst->lock); __nfulnl_send(inst); - instance_put(inst); spin_unlock_bh(&inst->lock); + instance_put(inst); } /* This is an inline function, we don't really care about a long |