aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2022-07-14 21:58:49 -0700
committerJakub Kicinski <kuba@kernel.org>2022-07-14 21:58:50 -0700
commit6e6fbb72e48ba3da229ff2158cf0d26aa50a218a (patch)
treec13b15a5cdfaca9c2ba382c62c4195672c7114d0 /net
parentMerge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (diff)
parentnet: devlink: fix return statement in devlink_port_new_notify() (diff)
downloadlinux-dev-6e6fbb72e48ba3da229ff2158cf0d26aa50a218a.tar.xz
linux-dev-6e6fbb72e48ba3da229ff2158cf0d26aa50a218a.zip
Merge branch 'net-devlink-couple-of-trivial-fixes'
Jiri Pirko says: ==================== net: devlink: couple of trivial fixes Just a couple of trivial fixes I found on the way. ==================== Link: https://lore.kernel.org/r/20220713141853.2992014-1-jiri@resnulli.us Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
-rw-r--r--net/core/devlink.c16
1 files changed, 7 insertions, 9 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 2b2e454ebd78..a9776ea923ae 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1700,9 +1700,9 @@ static int devlink_nl_cmd_port_unsplit_doit(struct sk_buff *skb,
return devlink->ops->port_unsplit(devlink, devlink_port, info->extack);
}
-static int devlink_port_new_notifiy(struct devlink *devlink,
- unsigned int port_index,
- struct genl_info *info)
+static int devlink_port_new_notify(struct devlink *devlink,
+ unsigned int port_index,
+ struct genl_info *info)
{
struct devlink_port *devlink_port;
struct sk_buff *msg;
@@ -1724,8 +1724,7 @@ static int devlink_port_new_notifiy(struct devlink *devlink,
if (err)
goto out;
- err = genlmsg_reply(msg, info);
- return err;
+ return genlmsg_reply(msg, info);
out:
nlmsg_free(msg);
@@ -1775,7 +1774,7 @@ static int devlink_nl_cmd_port_new_doit(struct sk_buff *skb,
if (err)
return err;
- err = devlink_port_new_notifiy(devlink, new_port_index, info);
+ err = devlink_port_new_notify(devlink, new_port_index, info);
if (err && err != -ENODEV) {
/* Fail to send the response; destroy newly created port. */
devlink->ops->port_del(devlink, new_port_index, extack);
@@ -10425,13 +10424,12 @@ EXPORT_SYMBOL_GPL(devlink_sb_unregister);
*
* Register the headers supported by hardware.
*/
-int devlink_dpipe_headers_register(struct devlink *devlink,
- struct devlink_dpipe_headers *dpipe_headers)
+void devlink_dpipe_headers_register(struct devlink *devlink,
+ struct devlink_dpipe_headers *dpipe_headers)
{
devl_lock(devlink);
devlink->dpipe_headers = dpipe_headers;
devl_unlock(devlink);
- return 0;
}
EXPORT_SYMBOL_GPL(devlink_dpipe_headers_register);