aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorMaciej ┼╗enczykowski <maze@google.com>2019-09-05 20:56:37 -0700
committerDavid S. Miller <davem@davemloft.net>2019-09-07 17:46:44 +0200
commit8652f17c658d03f5c87b8dee6e8e52480c6cd37d (patch)
tree6c5db08d73d4c16ae3cbce16cebc8b86a344632d /net
parentisdn/capi: check message length in capi_write() (diff)
downloadlinux-dev-8652f17c658d03f5c87b8dee6e8e52480c6cd37d.tar.xz
linux-dev-8652f17c658d03f5c87b8dee6e8e52480c6cd37d.zip
ipv6: addrconf_f6i_alloc - fix non-null pointer check to !IS_ERR()
Fixes a stupid bug I recently introduced... ip6_route_info_create() returns an ERR_PTR(err) and not a NULL on error. Fixes: d55a2e374a94 ("net-ipv6: fix excessive RTF_ADDRCONF flag on ::1/128 local route (and others)'") Cc: David Ahern <dsahern@gmail.com> Cc: Lorenzo Colitti <lorenzo@google.com> Cc: Eric Dumazet <edumazet@google.com> Signed-off-by: Maciej ┼╗enczykowski <maze@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv6/route.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 85bcd97f7a72..546088e50815 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -4406,7 +4406,7 @@ struct fib6_info *addrconf_f6i_alloc(struct net *net,
}
f6i = ip6_route_info_create(&cfg, gfp_flags, NULL);
- if (f6i)
+ if (!IS_ERR(f6i))
f6i->dst_nocount = true;
return f6i;
}