diff options
| author |   Masahiro Yamada <yamada.masahiro@socionext.com> | 2018-08-31 18:34:55 +0900 |
|---|---|---|
| committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2018-09-03 02:13:48 +0900 |
| commit | fd65465b7016dc6d9fa5c2f39cc706c231c9a089 (patch) | |
| tree | 56763fcfd78b59f7f8096a3616a34ef8fec30245 /scripts/kconfig/gconf-cfg.sh | |
| parent | kconfig: remove a spurious self-assignment (diff) | |
| download | linux-dev-fd65465b7016dc6d9fa5c2f39cc706c231c9a089.tar.xz linux-dev-fd65465b7016dc6d9fa5c2f39cc706c231c9a089.zip | |
kconfig: do not require pkg-config on make {menu,n}config
Meelis Roos reported a {menu,n}config regression:
"I have libncurses devel package installed in the default system
location (as do 99%+ on actual developers probably) and in this
case, pkg-config is useless. pkg-config is needed only when
libraries and headers are installed in non-default locations but
it is bad to require installation of pkg-config on all the machines
where make menuconfig would be possibly run."
For {menu,n}config, do not use pkg-config if it is not installed.
For {g,x}config, keep checking pkg-config since we really rely on it
for finding the installation paths of the required packages.
Fixes: 4ab3b80159d4 ("kconfig: check for pkg-config on make {menu,n,g,x}config")
Reported-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Meelis Roos <mroos@linux.ee>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Diffstat (limited to 'scripts/kconfig/gconf-cfg.sh')
| -rwxr-xr-x | scripts/kconfig/gconf-cfg.sh | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/scripts/kconfig/gconf-cfg.sh b/scripts/kconfig/gconf-cfg.sh index 533b3d8f8f08..480ecd8b9f41 100755 --- a/scripts/kconfig/gconf-cfg.sh +++ b/scripts/kconfig/gconf-cfg.sh @@ -3,6 +3,13 @@ PKG="gtk+-2.0 gmodule-2.0 libglade-2.0" +if [ -z "$(command -v pkg-config)" ]; then + echo >&2 "*" + echo >&2 "* 'make gconfig' requires 'pkg-config'. Please install it." + echo >&2 "*" + exit 1 +fi + if ! pkg-config --exists $PKG; then echo >&2 "*" echo >&2 "* Unable to find the GTK+ installation. Please make sure that" |