diff options
| author |   Xiao Yang <yangx.jy@cn.fujitsu.com> | 2020-03-18 18:34:16 +0800 |
|---|---|---|
| committer |   Masahiro Yamada <masahiroy@kernel.org> | 2020-03-19 01:44:25 +0900 |
| commit | 4b8a5cfb5fd375cf4c7502a18f0096ed2881be27 (patch) | |
| tree | 3c66d858c05e55a24bc624db84767aa6f7aa09dd /scripts/mod/modpost.c | |
| parent | initramfs: restore default compression behavior (diff) | |
| download | linux-dev-4b8a5cfb5fd375cf4c7502a18f0096ed2881be27.tar.xz linux-dev-4b8a5cfb5fd375cf4c7502a18f0096ed2881be27.zip | |
modpost: Get proper section index by get_secindex() instead of st_shndx
(uint16_t) st_shndx is limited to 65535(i.e. SHN_XINDEX) so sym_get_data() gets
wrong section index by st_shndx if requested symbol contains extended section
index that is more than 65535. In this case, we need to get proper section index
by .symtab_shndx section.
Module.symvers generated by building kernel with "-ffunction-sections -fdata-sections"
shows the issue.
Fixes: 56067812d5b0 ("kbuild: modversions: add infrastructure for emitting relative CRCs")
Fixes: e84f9fbbece1 ("modpost: refactor namespace_from_kstrtabns() to not hard-code section name")
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | scripts/mod/modpost.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 6ab235354f36..55a0a2eccbd2 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -308,7 +308,8 @@ static const char *sec_name(struct elf_info *elf, int secindex) static void *sym_get_data(const struct elf_info *info, const Elf_Sym *sym) { - Elf_Shdr *sechdr = &info->sechdrs[sym->st_shndx]; + unsigned int secindex = get_secindex(info, sym); + Elf_Shdr *sechdr = &info->sechdrs[secindex]; unsigned long offset; offset = sym->st_value; |