aboutsummaryrefslogtreecommitdiffstats
path: root/sound/core/seq/seq_virmidi.c
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2020-03-16 10:05:05 +0100
committerTakashi Iwai <tiwai@suse.de>2020-03-16 10:06:22 +0100
commit4384f167ce5fa7241b61bb0984d651bc528ddebe (patch)
tree8321a3fbd851f3fff306a09f39fcccdbe5475b69 /sound/core/seq/seq_virmidi.c
parentALSA: pcm: oss: Remove WARNING from snd_pcm_plug_alloc() checks (diff)
downloadlinux-dev-4384f167ce5fa7241b61bb0984d651bc528ddebe.tar.xz
linux-dev-4384f167ce5fa7241b61bb0984d651bc528ddebe.zip
ALSA: seq: virmidi: Fix running status after receiving sysex
The virmidi driver handles sysex event exceptionally in a short-cut snd_seq_dump_var_event() call, but this missed the reset of the running status. As a result, it may lead to an incomplete command right after the sysex when an event with the same running status was queued. Fix it by clearing the running status properly via alling snd_midi_event_reset_decode() for that code path. Reported-by: Andreas Steinmetz <ast@domdv.de> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/3b4a4e0f232b7afbaf0a843f63d0e538e3029bfd.camel@domdv.de Link: https://lore.kernel.org/r/20200316090506.23966-2-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to '')
-rw-r--r--sound/core/seq/seq_virmidi.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/core/seq/seq_virmidi.c b/sound/core/seq/seq_virmidi.c
index 626d87c1539b..77d7037d1476 100644
--- a/sound/core/seq/seq_virmidi.c
+++ b/sound/core/seq/seq_virmidi.c
@@ -81,6 +81,7 @@ static int snd_virmidi_dev_receive_event(struct snd_virmidi_dev *rdev,
if ((ev->flags & SNDRV_SEQ_EVENT_LENGTH_MASK) != SNDRV_SEQ_EVENT_LENGTH_VARIABLE)
continue;
snd_seq_dump_var_event(ev, (snd_seq_dump_func_t)snd_rawmidi_receive, vmidi->substream);
+ snd_midi_event_reset_decode(vmidi->parser);
} else {
len = snd_midi_event_decode(vmidi->parser, msg, sizeof(msg), ev);
if (len > 0)