diff options
| author |   Andrew Gabbasov <andrew_gabbasov@mentor.com> | 2019-11-27 05:06:22 -0600 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2019-11-27 12:16:00 +0100 |
| commit | 5061bb7065d05efbac35a660eb30ed4c3100690b (patch) | |
| tree | 3df2de81053fc1a7409afc5b92d0095688289b83 /sound/pci/hda/patch_hdmi.c | |
| parent | ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by default (diff) | |
| download | linux-dev-5061bb7065d05efbac35a660eb30ed4c3100690b.tar.xz linux-dev-5061bb7065d05efbac35a660eb30ed4c3100690b.zip | |
ALSA: aloop: Avoid pointer dereference before null-check
Static analysis tools (cppcheck and PVS Studio) report an error
in loopback_snd_timer_period_elapsed() regarding dpcm_play pointer
dereference earlier than its null-check. And although this is a result
of a formal check, and the pointer correctness is also protected
by having a corresponding bit set in the "running" mask, re-ordering
of the lines can imake the code even formally correct and eliminate
those static analysis error reports.
Fixes: 26c53379f98d ("ALSA: aloop: Support selection of snd_timer instead of jiffies")
Reported-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Link: https://lore.kernel.org/r/20191127110622.26105-1-andrew_gabbasov@mentor.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/hda/patch_hdmi.c')
0 files changed, 0 insertions, 0 deletions