diff options
| author |   Chuhong Yuan <hslester96@gmail.com> | 2020-05-28 18:20:04 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2020-05-28 13:20:20 +0100 |
| commit | 8dc1011470315501914a4527276b7b93301f3d38 (patch) | |
| tree | 30278c0222bc7f47c832aa457e4b2e7207c34999 /sound/soc/codecs/sta32x.c | |
| parent | ASoC: rt5682: split i2c driver into separate module (diff) | |
| download | linux-dev-8dc1011470315501914a4527276b7b93301f3d38.tar.xz linux-dev-8dc1011470315501914a4527276b7b93301f3d38.zip | |
ASoC: sta32x: add missed function calls in error paths
sta32x_probe() forgets to call undo functions when it fails, add
the missed function calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20200528102004.911653-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | sound/soc/codecs/sta32x.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index db4b3ec55311..e9ccebbc31e4 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -893,13 +893,13 @@ static int sta32x_probe(struct snd_soc_component *component) sta32x->supplies); if (ret != 0) { dev_err(component->dev, "Failed to enable supplies: %d\n", ret); - return ret; + goto err_clk_disable_unprepare; } ret = sta32x_startup_sequence(sta32x); if (ret < 0) { dev_err(component->dev, "Failed to startup device\n"); - return ret; + goto err_regulator_bulk_disable; } /* CONFA */ @@ -983,6 +983,13 @@ static int sta32x_probe(struct snd_soc_component *component) regulator_bulk_disable(ARRAY_SIZE(sta32x->supplies), sta32x->supplies); return 0; + +err_regulator_bulk_disable: + regulator_bulk_disable(ARRAY_SIZE(sta32x->supplies), sta32x->supplies); +err_clk_disable_unprepare: + if (sta32x->xti_clk) + clk_disable_unprepare(sta32x->xti_clk); + return ret; } static void sta32x_remove(struct snd_soc_component *component) |