aboutsummaryrefslogtreecommitdiffstats
path: root/sound/soc/intel/sst-firmware.c
diff options
context:
space:
mode:
authorChristian Engelmayer <cengelma@gmx.at>2014-04-13 22:46:31 +0200
committerMark Brown <broonie@linaro.org>2014-04-15 12:12:34 +0100
commitdd1b94bf4920cc12545883faa43c014efbf61b1e (patch)
treed5e58f505ff2a753ce0655057acb77ed6eb0bcd8 /sound/soc/intel/sst-firmware.c
parentASoC: Intel: Fix incorrect sizeof() in sst_hsw_stream_get_volume() (diff)
downloadlinux-dev-dd1b94bf4920cc12545883faa43c014efbf61b1e.tar.xz
linux-dev-dd1b94bf4920cc12545883faa43c014efbf61b1e.zip
ASoC: Intel: Fix a self assignment in sst_mem_block_alloc_scratch()
Remove a self assignment in sst_mem_block_alloc_scratch(). When calculating buffer sizes there is no need for statements without effect. Detected by Coverity: CID 1195249. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to '')
-rw-r--r--sound/soc/intel/sst-firmware.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/sound/soc/intel/sst-firmware.c b/sound/soc/intel/sst-firmware.c
index f7687107cf7f..f24619adc3d1 100644
--- a/sound/soc/intel/sst-firmware.c
+++ b/sound/soc/intel/sst-firmware.c
@@ -505,9 +505,7 @@ struct sst_module *sst_mem_block_alloc_scratch(struct sst_dsp *dsp)
/* calculate required scratch size */
list_for_each_entry(sst_module, &dsp->module_list, list) {
- if (scratch->s.size > sst_module->s.size)
- scratch->s.size = scratch->s.size;
- else
+ if (scratch->s.size < sst_module->s.size)
scratch->s.size = sst_module->s.size;
}