diff options
| author |   Jianglei Nie <niejianglei2021@163.com> | 2022-06-30 02:25:20 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-07-07 17:16:36 +0100 |
| commit | df5b4aca7248dc5a5cae93f162eae0decf972e48 (patch) | |
| tree | e97b89539ea2a7d71c9b9700ffd325ca2d8cb993 /sound/soc/qcom/qdsp6/q6apm.c | |
| parent | ASoC: tas2764: Fix amp gain register offset & default (diff) | |
| download | linux-dev-df5b4aca7248dc5a5cae93f162eae0decf972e48.tar.xz linux-dev-df5b4aca7248dc5a5cae93f162eae0decf972e48.zip | |
ASoC: qdsp6: fix potential memory leak in q6apm_get_audioreach_graph()
q6apm_get_audioreach_graph() allocates a memory chunk for graph->graph
with audioreach_alloc_graph_pkt(). When idr_alloc() fails, graph->graph
is not released, which will lead to a memory leak.
We can release the graph->graph with kfree() when idr_alloc() fails to
fix the memory leak.
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220629182520.2164409-1-niejianglei2021@163.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | sound/soc/qcom/qdsp6/q6apm.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index f424d7aa389a..794019286c70 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -75,6 +75,7 @@ static struct audioreach_graph *q6apm_get_audioreach_graph(struct q6apm *apm, ui id = idr_alloc(&apm->graph_idr, graph, graph_id, graph_id + 1, GFP_KERNEL); if (id < 0) { dev_err(apm->dev, "Unable to allocate graph id (%d)\n", graph_id); + kfree(graph->graph); kfree(graph); mutex_unlock(&apm->lock); return ERR_PTR(id); |