diff options
| author |   Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2022-06-09 11:59:48 +0300 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-06-24 16:21:38 +0100 |
| commit | c31691e0d126ec5d60d2b6b03f699c11b613b219 (patch) | |
| tree | bd429b5b130ce38459ed8e63f5c047d9791d3d77 /sound/soc/sof/intel/hda-loader.c | |
| parent | ASoC: SOF: Intel: hda-dsp: Expose hda_dsp_core_power_up() (diff) | |
| download | linux-dev-c31691e0d126ec5d60d2b6b03f699c11b613b219.tar.xz linux-dev-c31691e0d126ec5d60d2b6b03f699c11b613b219.zip | |
ASoC: SOF: Intel: hda-loader: Make sure that the fw load sequence is followed
The hda_dsp_enable_core() is powering up _and_ unstall the core in one
call while the first step of the firmware loading must not unstall the
core.
The core can be unstalled only after the set cpb_cfp and the configuration
of the IPC register for the ROM_CONTROL message.
Complements: 2a68ff846164 ("ASoC: SOF: Intel: hda: Revisit IMR boot sequence")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20220609085949.29062-3-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | sound/soc/sof/intel/hda-loader.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/sof/intel/hda-loader.c b/sound/soc/sof/intel/hda-loader.c index 64290125d7cd..103e62bcfa82 100644 --- a/sound/soc/sof/intel/hda-loader.c +++ b/sound/soc/sof/intel/hda-loader.c @@ -110,7 +110,7 @@ static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot) int ret; /* step 1: power up corex */ - ret = hda_dsp_enable_core(sdev, chip->host_managed_cores_mask); + ret = hda_dsp_core_power_up(sdev, chip->host_managed_cores_mask); if (ret < 0) { if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS) dev_err(sdev->dev, "error: dsp core 0/1 power up failed\n"); |