diff options
| author |   Quentin Monnet <quentin.monnet@netronome.com> | 2018-10-20 23:01:50 +0100 |
|---|---|---|
| committer |   Daniel Borkmann <daniel@iogearbox.net> | 2018-10-21 20:45:14 +0200 |
| commit | fe8ecccc10b3adc071de05ca7af728ca1a4ac9aa (patch) | |
| tree | e331ea6c91c3da4fc356cbaed02d0cceff29bdbb /tools/bpf/bpftool/bash-completion/bpftool | |
| parent | tools: bpftool: print nb of cmds to stdout (not stderr) for batch mode (diff) | |
| download | linux-dev-fe8ecccc10b3adc071de05ca7af728ca1a4ac9aa.tar.xz linux-dev-fe8ecccc10b3adc071de05ca7af728ca1a4ac9aa.zip | |
tools: bpftool: fix completion for "bpftool map update"
When trying to complete "bpftool map update" commands, the call to
printf would print an error message that would show on the command line
if no map is found to complete the command line.
Fix it by making sure we have map ids to complete the line with, before
we try to print something.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to '')
| -rw-r--r-- | tools/bpf/bpftool/bash-completion/bpftool | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool index c56545e87b0d..3f78e6404589 100644 --- a/tools/bpf/bpftool/bash-completion/bpftool +++ b/tools/bpf/bpftool/bash-completion/bpftool @@ -143,7 +143,7 @@ _bpftool_map_update_map_type() local type type=$(bpftool -jp map show $keyword $ref | \ command sed -n 's/.*"type": "\(.*\)",$/\1/p') - printf $type + [[ -n $type ]] && printf $type } _bpftool_map_update_get_id() |