diff options
| author |   Quentin Monnet <quentin.monnet@netronome.com> | 2017-10-19 15:46:25 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-22 02:11:32 +0100 |
| commit | 8dfbc6d1d213df340e5dcfdcdc76ad9407a29273 (patch) | |
| tree | 5cb270c2ea3c6c02b8669e6bb6427eaf3cc3a311 /tools/bpf/bpftool/prog.c | |
| parent | tools: bpftool: print all relevant byte opcodes for "load double word" (diff) | |
| download | linux-dev-8dfbc6d1d213df340e5dcfdcdc76ad9407a29273.tar.xz linux-dev-8dfbc6d1d213df340e5dcfdcdc76ad9407a29273.zip | |
tools: bpftool: show that `opcodes` or `file FILE` should be exclusive
For the `bpftool prog dump { jited | xlated } ...` command, adding
`opcodes` keyword (to request opcodes to be printed) will have no effect
if `file FILE` (to write binary output to FILE) is provided.
The manual page and the help message to be displayed in the terminal
should reflect that, and indicate that these options should be mutually
exclusive.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | tools/bpf/bpftool/prog.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c index 57edbea2fbe8..7838206a455b 100644 --- a/tools/bpf/bpftool/prog.c +++ b/tools/bpf/bpftool/prog.c @@ -469,8 +469,8 @@ static int do_help(int argc, char **argv) { fprintf(stderr, "Usage: %s %s show [PROG]\n" - " %s %s dump xlated PROG [file FILE] [opcodes]\n" - " %s %s dump jited PROG [file FILE] [opcodes]\n" + " %s %s dump xlated PROG [{ file FILE | opcodes }]\n" + " %s %s dump jited PROG [{ file FILE | opcodes }]\n" " %s %s pin PROG FILE\n" " %s %s help\n" "\n" |