diff options
| author |   Jiri Olsa <jolsa@kernel.org> | 2018-09-23 17:04:20 +0200 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2018-11-06 08:29:56 -0300 |
| commit | 8e88c29b351ed4e09dd63f825f1c8260b0cb0ab3 (patch) | |
| tree | b7e0e6eb69b055ecb3c9ea0d93423cdaa297b8fa /tools/perf/util/evsel.c | |
| parent | perf tools: Fix undefined symbol scnprintf in libperf-jvmti.so (diff) | |
| download | linux-dev-8e88c29b351ed4e09dd63f825f1c8260b0cb0ab3.tar.xz linux-dev-8e88c29b351ed4e09dd63f825f1c8260b0cb0ab3.zip | |
perf tools: Do not zero sample_id_all for group members
Andi reported following malfunction:
# perf record -e '{ref-cycles,cycles}:S' -a sleep 1
# perf script
non matching sample_id_all
That's because we disable sample_id_all bit for non-sampling group
members. We can't do that, because it needs to be the same over the
whole event list. This patch keeps it untouched again.
Reported-by: Andi Kleen <andi@firstfloor.org>
Tested-by: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180923150420.27327-1-jolsa@kernel.org
Fixes: e9add8bac6c6 ("perf evsel: Disable write_backward for leader sampling group events")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | tools/perf/util/evsel.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 6d187059a373..d37bb1566cd9 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -956,7 +956,6 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, attr->sample_freq = 0; attr->sample_period = 0; attr->write_backward = 0; - attr->sample_id_all = 0; } if (opts->no_samples) |