diff options
| author |   Adrian Hunter <adrian.hunter@intel.com> | 2013-09-22 13:22:09 +0300 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-10-11 12:17:27 -0300 |
| commit | f4be904d2fa7c65e230ed4b1008ebdf5f4053ac3 (patch) | |
| tree | 19c857540882530cf6cb2f4b154bdbddd1ccc369 /tools/perf/util/machine.c | |
| parent | perf bench sched: Add --threaded option (diff) | |
| download | linux-dev-f4be904d2fa7c65e230ed4b1008ebdf5f4053ac3.tar.xz linux-dev-f4be904d2fa7c65e230ed4b1008ebdf5f4053ac3.zip | |
perf machine: Use snprintf instead of sprintf
To avoid buffer overruns.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1379845338-29637-2-git-send-email-adrian.hunter@intel.com
[ Split from aa7fe3b ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | tools/perf/util/machine.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 6188d2876a71..ddf917b787fa 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -785,10 +785,10 @@ static int machine__create_modules(struct machine *machine) const char *modules; char path[PATH_MAX]; - if (machine__is_default_guest(machine)) + if (machine__is_default_guest(machine)) { modules = symbol_conf.default_guest_modules; - else { - sprintf(path, "%s/proc/modules", machine->root_dir); + } else { + snprintf(path, PATH_MAX, "%s/proc/modules", machine->root_dir); modules = path; } |