aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util/util.h
diff options
context:
space:
mode:
authorJiri Olsa <jolsa@kernel.org>2018-11-12 14:00:12 +0100
committerArnaldo Carvalho de Melo <acme@redhat.com>2018-11-12 08:37:49 -0800
commitfb50c09e923870a358d68b0d58891bd145b8d7c7 (patch)
tree5526b57bfa4f48461e5d873857a3ea42e0376010 /tools/perf/util/util.h
parentperf/x86/intel/uncore: Support CoffeeLake 8th CBOX (diff)
downloadlinux-dev-fb50c09e923870a358d68b0d58891bd145b8d7c7.tar.xz
linux-dev-fb50c09e923870a358d68b0d58891bd145b8d7c7.zip
perf tools: Fix crash on synthesizing the unit
Adam reported a record command crash for simple session like: $ perf record -e cpu-clock ls with following backtrace: Program received signal SIGSEGV, Segmentation fault. 3543 ev = event_update_event__new(size + 1, PERF_EVENT_UPDATE__UNIT, evsel->id[0]); (gdb) bt #0 perf_event__synthesize_event_update_unit #1 0x000000000051e469 in perf_event__synthesize_extra_attr #2 0x00000000004445cb in record__synthesize #3 0x0000000000444bc5 in __cmd_record ... We synthesize an update event that needs to touch the evsel id array, which is not defined at that time. Fix this by forcing the id allocation for events with their unit defined. Reflecting possible read_format ID bit in the attr tests. Reported-by: Yongxin Liu <yongxin.liu@outlook.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Cc: Adam Lee <leeadamrobert@gmail.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201477 Fixes: bfd8f72c2778 ("perf record: Synthesize unit/scale/... in event update") Link: http://lkml.kernel.org/r/20181112130012.5424-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/util.h')
0 files changed, 0 insertions, 0 deletions