diff options
| author |   Dan Williams <dan.j.williams@intel.com> | 2016-12-16 08:10:31 -0800 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2016-12-16 08:10:31 -0800 |
| commit | 868f036fee4b1f934117197fb93461d2c968ffec (patch) | |
| tree | 2ccd2f941f1a6321d15d0c6c948fd527ebeae469 /tools/testing/nvdimm | |
| parent | libnvdimm: replace mutex_is_locked() warnings with lockdep_assert_held (diff) | |
| download | linux-dev-868f036fee4b1f934117197fb93461d2c968ffec.tar.xz linux-dev-868f036fee4b1f934117197fb93461d2c968ffec.zip | |
libnvdimm: fix mishandled nvdimm_clear_poison() return value
Colin, via static analysis, reports that the length could be negative
from nvdimm_clear_poison() in the error case. There was a similar
problem with commit 0a3f27b9a6a8 "libnvdimm, namespace: avoid multiple
sector calculations" that I noticed when merging the for-4.10/libnvdimm
topic branch into libnvdimm-for-next, but I missed this one. Fix both of
them to the following procedure:
* if we clear a block's worth of media, clear that many blocks in
badblocks
* if we clear less than the requested size of the transfer return an
error
* always invalidate cache after any non-error / non-zero
nvdimm_clear_poison result
Fixes: 82bf1037f2ca ("libnvdimm: check and clear poison before writing to pmem")
Fixes: 0a3f27b9a6a8 ("libnvdimm, namespace: avoid multiple sector calculations")
Cc: Fabian Frederick <fabf@skynet.be>
Cc: Dave Jiang <dave.jiang@intel.com>
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'tools/testing/nvdimm')
0 files changed, 0 insertions, 0 deletions