path: root/tools/testing/radix-tree/regression.h
diff options
authorMatthew Wilcox <willy@infradead.org>2018-12-06 08:19:13 -0500
committerMatthew Wilcox <willy@infradead.org>2018-12-06 08:26:16 -0500
commiteff3860bbfedbac6edac57fb0d7f3a60e860c1c3 (patch)
tree99b3f3e6321a16cfba84319c4a94a1aa653e68d9 /tools/testing/radix-tree/regression.h
parentMerge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi (diff)
radix tree: Don't return retry entries from lookup
Commit 66ee620f06f9 ("idr: Permit any valid kernel pointer to be stored") changed the radix tree lookup so that it stops when reaching the bottom of the tree. However, the condition was added in the wrong place, making it possible to return retry entries to the caller. Reorder the tests to check for the retry entry before checking whether we're at the bottom of the tree. The retry entry should never be found in the tree root, so it's safe to defer the check until the end of the loop. Add a regression test to the test-suite to be sure this doesn't come back. Fixes: 66ee620f06f9 ("idr: Permit any valid kernel pointer to be stored") Reported-by: Greg Kurz <groug@kaod.org> Signed-off-by: Matthew Wilcox <willy@infradead.org>
Diffstat (limited to '')
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/testing/radix-tree/regression.h b/tools/testing/radix-tree/regression.h
index 3c8a1584e9ee..135145af18b7 100644
--- a/tools/testing/radix-tree/regression.h
+++ b/tools/testing/radix-tree/regression.h
@@ -5,5 +5,6 @@
void regression1_test(void);
void regression2_test(void);
void regression3_test(void);
+void regression4_test(void);