diff options
| author |   Andrei Vagin <avagin@gmail.com> | 2019-11-17 22:47:50 -0800 |
|---|---|---|
| committer |   Christian Brauner <christian.brauner@ubuntu.com> | 2019-11-18 08:57:59 +0100 |
| commit | a019ff3b8b10d1b7f5cd37edb9f4fbef3e031edf (patch) | |
| tree | fc17c4497fe6b56f9b5343b8655aaa3a6c64dcc4 /tools/testing/selftests/clone3 | |
| parent | selftests/clone3: report a correct number of fails (diff) | |
| download | linux-dev-a019ff3b8b10d1b7f5cd37edb9f4fbef3e031edf.tar.xz linux-dev-a019ff3b8b10d1b7f5cd37edb9f4fbef3e031edf.zip | |
selftests/clone3: check that all pids are released on error paths
This is a regression test case for an issue when pids have not been
released on error paths.
Signed-off-by: Andrei Vagin <avagin@gmail.com>
Link: https://lore.kernel.org/r/20191118064750.408003-3-avagin@gmail.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Diffstat (limited to 'tools/testing/selftests/clone3')
| -rw-r--r-- | tools/testing/selftests/clone3/clone3_set_tid.c | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c index 9c19bae03661..c6309f5d7d88 100644 --- a/tools/testing/selftests/clone3/clone3_set_tid.c +++ b/tools/testing/selftests/clone3/clone3_set_tid.c @@ -160,7 +160,7 @@ int main(int argc, char *argv[]) ksft_exit_fail_msg("pipe() failed\n"); ksft_print_header(); - ksft_set_plan(27); + ksft_set_plan(29); f = fopen("/proc/sys/kernel/pid_max", "r"); if (f == NULL) @@ -290,6 +290,18 @@ int main(int argc, char *argv[]) /* Let's create a PID 1 */ ns_pid = fork(); if (ns_pid == 0) { + /* + * This and the next test cases check that all pid-s are + * released on error paths. + */ + set_tid[0] = 43; + set_tid[1] = -1; + test_clone3_set_tid(set_tid, 2, 0, -EINVAL, 0, 0); + + set_tid[0] = 43; + set_tid[1] = pid; + test_clone3_set_tid(set_tid, 2, 0, 0, 43, 0); + ksft_print_msg("Child in PID namespace has PID %d\n", getpid()); set_tid[0] = 2; test_clone3_set_tid(set_tid, 1, 0, 0, 2, 0); @@ -366,7 +378,7 @@ int main(int argc, char *argv[]) if (!WIFEXITED(status)) ksft_test_result_fail("Child error\n"); - ksft_cnt.ksft_pass += 4 - (ksft_cnt.ksft_fail - WEXITSTATUS(status)); + ksft_cnt.ksft_pass += 6 - (ksft_cnt.ksft_fail - WEXITSTATUS(status)); ksft_cnt.ksft_fail = WEXITSTATUS(status); if (ns3 == pid && ns2 == 42 && ns1 == 1) |