diff options
| author |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-12-18 22:34:20 +0100 |
|---|---|---|
| committer |   Shuah Khan <shuah@kernel.org> | 2019-01-14 18:49:05 -0700 |
| commit | fdac94489c4d247088b3885875b39b3e1eb621ef (patch) | |
| tree | 0fab788e0e87e3bd930d748afbda0912d84d96f3 /tools/testing/selftests/rtc | |
| parent | Linux 5.0-rc1 (diff) | |
| download | linux-dev-fdac94489c4d247088b3885875b39b3e1eb621ef.tar.xz linux-dev-fdac94489c4d247088b3885875b39b3e1eb621ef.zip | |
selftests: rtc: rtctest: fix alarm tests
Return values for select are not checked properly and timeouts may not be
detected.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Shuah Khan <shuah@kernel.org>
Diffstat (limited to 'tools/testing/selftests/rtc')
| -rw-r--r-- | tools/testing/selftests/rtc/rtctest.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/tools/testing/selftests/rtc/rtctest.c b/tools/testing/selftests/rtc/rtctest.c index e20b017e7073..dea4e3d6d9e1 100644 --- a/tools/testing/selftests/rtc/rtctest.c +++ b/tools/testing/selftests/rtc/rtctest.c @@ -145,15 +145,12 @@ TEST_F(rtc, alarm_alm_set) { rc = select(self->fd + 1, &readfds, NULL, NULL, &tv); ASSERT_NE(-1, rc); - EXPECT_NE(0, rc); + ASSERT_NE(0, rc); /* Disable alarm interrupts */ rc = ioctl(self->fd, RTC_AIE_OFF, 0); ASSERT_NE(-1, rc); - if (rc == 0) - return; - rc = read(self->fd, &data, sizeof(unsigned long)); ASSERT_NE(-1, rc); TH_LOG("data: %lx", data); @@ -202,7 +199,7 @@ TEST_F(rtc, alarm_wkalm_set) { rc = select(self->fd + 1, &readfds, NULL, NULL, &tv); ASSERT_NE(-1, rc); - EXPECT_NE(0, rc); + ASSERT_NE(0, rc); rc = read(self->fd, &data, sizeof(unsigned long)); ASSERT_NE(-1, rc); |