aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorBreno Leitao <leitao@debian.org>2018-06-26 10:20:12 -0300
committerMichael Ellerman <mpe@ellerman.id.au>2018-07-02 23:59:39 +1000
commit09a61e894ac852fb063ee0b54fc513b13abcab08 (patch)
treef8db02ec643e5b83034caa30269c8b9dffbae54e /tools
parentcxl: Remove abandonned capi support for the Mellanox CX4, final cleanup (diff)
downloadlinux-dev-09a61e894ac852fb063ee0b54fc513b13abcab08.tar.xz
linux-dev-09a61e894ac852fb063ee0b54fc513b13abcab08.zip
selftests/powerpc: Fix strncpy usage
There is a buffer overflow in dscr_inherit_test.c test. In main(), strncpy()'s third argument is the length of the source, not the size of the destination buffer, which makes strncpy() behaves like strcpy(), causing a buffer overflow if argv[0] is bigger than LEN_MAX (100). This patch maps 'prog' to the argv[0] memory region, removing the static allocation and the LEN_MAX size restriction. Signed-off-by: Breno Leitao <leitao@debian.org> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'tools')
-rw-r--r--tools/testing/selftests/powerpc/dscr/dscr_inherit_exec_test.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/selftests/powerpc/dscr/dscr_inherit_exec_test.c b/tools/testing/selftests/powerpc/dscr/dscr_inherit_exec_test.c
index 08a8b95e3bc1..55c55f39b6a6 100644
--- a/tools/testing/selftests/powerpc/dscr/dscr_inherit_exec_test.c
+++ b/tools/testing/selftests/powerpc/dscr/dscr_inherit_exec_test.c
@@ -19,7 +19,7 @@
*/
#include "dscr.h"
-static char prog[LEN_MAX];
+static char *prog;
static void do_exec(unsigned long parent_dscr)
{
@@ -104,6 +104,6 @@ int main(int argc, char *argv[])
exit(1);
}
- strncpy(prog, argv[0], strlen(argv[0]));
+ prog = argv[0];
return test_harness(dscr_inherit_exec, "dscr_inherit_exec_test");
}