diff options
| author |   Cengiz Can <cengiz@kernel.wtf> | 2020-01-20 17:15:54 +0300 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2020-01-31 09:40:50 +0100 |
| commit | 85fc95d75970ee7dd8e01904e7fb1197c275ba6b (patch) | |
| tree | 11a21f28a52973364bba9ac928f4809c90eef8dd /tools | |
| parent | perf probe: Add ustring support for perf probe command (diff) | |
| download | linux-dev-85fc95d75970ee7dd8e01904e7fb1197c275ba6b.tar.xz linux-dev-85fc95d75970ee7dd8e01904e7fb1197c275ba6b.zip | |
perf maps: Add missing unlock to maps__insert() error case
`tools/perf/util/map.c` has a function named `maps__insert` that
acquires a write lock if its in multithread context.
Even though this lock is released when function successfully completes,
there's a branch that is executed when `maps_by_name == NULL` that
returns from this function without releasing the write lock.
Added an `up_write` to release the lock when this happens.
Fixes: a7c2b572e217 ("perf map_groups: Auto sort maps by name, if needed")
Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lore.kernel.org/lkml/20200120141553.23934-1-cengiz@kernel.wtf
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/map.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c index fdd5bddb3075..f67960bedebb 100644 --- a/tools/perf/util/map.c +++ b/tools/perf/util/map.c @@ -549,6 +549,7 @@ void maps__insert(struct maps *maps, struct map *map) if (maps_by_name == NULL) { __maps__free_maps_by_name(maps); + up_write(&maps->lock); return; } |