aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-04-29nubus: Don't use create_proc_read_entry()David Howells3-60/+80
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: linux-m68k@lists.linux-m68k.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29fsl_udc: Don't use create_proc_read_entry()David Howells1-81/+43
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: Li Yang <leoli@freescale.com> cc: Felipe Balbi <balbi@ti.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-usb@vger.kernel.org cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29goku_udc: Don't use create_proc_read_entry()David Howells1-50/+39
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: Felipe Balbi <balbi@ti.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-usb@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29wlags49_h2: Don't use create_proc_read_entry()David Howells1-159/+161
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: Henk de Groot <pe1dnn@amsat.org> cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-wireless@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29cxt1e1: Don't use create_proc_read_entry()David Howells3-302/+175
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: Bob Beers <bob.beers@gmail.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: devel@driverdev.osuosl.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29csr: Don't use create_proc_read_entry()David Howells3-332/+189
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Randy Dunlap <rdunlap@xenotime.net> cc: Priit Laes <plaes@plaes.org> cc: devel@driverdev.osuosl.org cc: Mikko Virkkilä <mikko.virkkila@bluegiga.com> cc: Lauri Hintsala <Lauri.Hintsala@bluegiga.com> cc: Riku Mettälä <riku.mettala@bluegiga.com> cc: Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29comedi: Don't use create_proc_read_entry()David Howells1-21/+31
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: David Schleef <ds@schleef.org> cc: Ian Abbott <abbotti@mev.co.uk> cc: Mori Hess <fmhess@users.sourceforge.net> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: H Hartley Sweeten <hsweeten@visionengravers.com> cc: devel@driverdev.osuosl.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29ft1000: Don't use create_proc_read_entry()David Howells2-136/+123
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: Marek Belisko <marek.belisko@gmail.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Ondrej Zary <linux@rainbow-software.org> cc: devel@driverdev.osuosl.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29rtl8187se: Don't use create_proc_read_entry()David Howells1-71/+63
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Whilst we're at it, reduce the number of show functions where we can share them. Question: Do any of the registers read by proc_get_registers() have side effects upon reading? If so, locking will be required. Signed-off-by: David Howells <dhowells@redhat.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: Maxim Mikityanskiy <maxtram95@gmail.com> cc: YAMANE Toshiaki <yamanetoshi@gmail.com> cc: Bill Pemberton <wfp5p@virginia.edu> cc: Andrea Merello <andreamrl@tiscali.it> cc: linux-wireless@vger.kernel.org cc: devel@driverdev.osuosl.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29rtl8192u: Don't use create_proc_read_entry()David Howells1-123/+91
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Whilst we're at it, reduce the number of show functions where we can share them. Note: proc_get_stats_ap() should probably use seq_file iteration rather than list_for_each_entry(). Further note: There appears to be a lot of locking missing in this file to defend against concurrent access by the driver doing normal operations. Notably, ieee->network_list traversal and RWCAM/RCAMO command/response access. Further, do any of the registers read have side effects upon reading? Signed-off-by: David Howells <dhowells@redhat.com> cc: Jerry Chuang <jerry-chuang@realtek.com> cc: Mauro Carvalho Chehab <mchehab@redhat.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-wireless@vger.kernel.org cc: devel@driverdev.osuosl.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29procfs: Mark create_proc_read_entry deprecatedDavid Howells1-2/+4
Mark create_proc_read_entry deprecated. proc_create[_data]() should be used instead. Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29xt_hashlimit: allocate a copy of name explicitly, don't rely on procfs gutsAl Viro1-3/+11
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mISDN: grabbing/dropping reference to THIS_MODULE in open/release is racyAl Viro1-2/+1
... when you have no ->owner set. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mISDN: fix mISDN_read()/mISDN_read() raceAl Viro1-9/+14
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mISDN: fix misdn_add_timer()/misdn_del_timer() raceAl Viro1-9/+5
do add_timer() *before* unlocking dev->lock, or unpleasant things can happen if misdn_del_timer() on another CPU finds the sucker, calls del_timer_sync() (which does nothing, since we hadn't started the timer yet) and frees it, just as we get around to add_timer()... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mISDN: fix races between misdn_del_timer() and timer callbackAl Viro1-13/+9
mark the victim with negative ->id if misdn_del_timer() finds it on the list, have timer callback *not* move ones so marked to dev->expired Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mISDN: fix the races with timers going off just as they are deletedAl Viro1-2/+12
timer callback in timerdev.c both accesses struct mISDNtimer it's called for *and* moves it to dev->expired. We need del_timer_sync(), or we risk kfree() freeing it right under dev_expire_timer() *and* dev->expired getting corrupted. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29dvb_frontend: don't mess with ->f_op in ->release()Al Viro1-4/+1
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29dvb_net: don't mess with ->f_op in ->release()Al Viro1-4/+1
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29lis3lv02d: don't wank with fasync() on ->release()Al Viro1-1/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mpt3sas: don't wank with fasync on ->release()Al Viro1-14/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mpt2sas: don't wank with fasync on ->release()Al Viro1-14/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29fix a leak in /proc/schedstatsAl Viro1-6/+1
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29pmcraid: don't wank with fasync in ->release()Al Viro1-14/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29mptctl: don't wank with fasync in ->release()Al Viro1-8/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29lpfc: fix races for miscdevice open vs. rmmodAl Viro1-32/+1
mind you, I'm not sure WTF would anybody _need_ that miscdevice at all - no IO is possible for it, opening it only pins the module down and is seriously racy, at that. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29yurex: don't wank with fasync on ->release()...Al Viro1-2/+0
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29fanotify: don't wank with FASYNC on ->release()Al Viro1-3/+0
... it's done already by __fput() Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29sock_close() couldn't have been called with NULL inode since at least 2.1.earlyAl Viro1-9/+0
... if not since 0.99 or so. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29tomoyo_close_control: don't bother with return valueAl Viro3-8/+4
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29dmasound_core: saner arguments for sq_fsync()Al Viro1-3/+3
it is not (and it has never been) an ->fsync() instance... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29hppfs: get rid of ->fsync()Al Viro1-7/+0
it has grown by accident - directories there do *not* use page cache, so there's nothing to write. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29hppfs: fix the leaks on close()Al Viro1-1/+12
we need to close the underlying procfs file and free ->private_data Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-29new helper: read_code()Al Viro6-67/+42
switch binfmts that use ->read() to that (and to kernel_read() in several cases in binfmt_flat - sure, it's nommu, but still, doing ->read() into kmalloc'ed buffer...) Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-13cx25821: sanitize cx25821_openfile_audio() a bit...Al Viro1-68/+28
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-13cx25821: sanitize cx25821_get_audio_data() a bitAl Viro1-58/+25
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09try a saner locking for pde_opener...Al Viro3-44/+24
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09deal with races between remove_proc_entry() and proc_reg_release()Al Viro2-53/+34
* serialize the call of ->release() on per-pdeo mutex * don't remove pdeo from per-pde list until we are through with it Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09procfs: preparations for remove_proc_entry() race fixesAl Viro4-214/+135
* leave ->proc_fops alone; make ->pde_users negative instead * trim pde_opener * move relevant code in fs/proc/inode.c Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09procfs: Clean up huge if-statement in __proc_file_read()David Howells1-51/+47
Switch huge if-statement in __proc_file_read() around. This then puts the single line loop break immediately after the if-statement and allows us to de-indent the huge comment and make it take fewer lines. The code following the if-statement then follows naturally from the call to dp->read_proc(). Signed-off-by: David Howells <dhowells@redhat.com>
2013-04-09vt6655: slightly clean reading config fileAl Viro1-75/+40
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09vt6656: slightly sanitized reading configAl Viro1-43/+20
Just reading - parsing the results is left alone (and unspeakably lousy). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09sound_firmware: don't bother with filp_close()Al Viro1-4/+5
it's opened read-only and never installed into any descriptor tables; fput() will do just as well. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09pxa3xx-gcu: stop embedding file_operations into device-private objectAl Viro1-7/+8
no need to do that anymore... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09pxa3xx-gcu: quite playing silly buggers with ->f_opAl Viro1-9/+12
misc device gets ->private_data pointing to struct miscdevice on open(), so we can use that to get to per-device structure instead of relying on file_operations being copied into it. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-09silicom-bypass: Remove device_open/close()David Howells1-24/+0
Remove device_open/close() functions as they don't really do anything and remove Device_Open as it isn't counted atomically and the value isn't used. Signed-off-by: David Howells <dhowells@redhat.com>
2013-04-09proc: Kill create_proc_entry()David Howells2-18/+8
Kill create_proc_entry() in favour of create_proc_read_entry(), proc_create() and proc_create_data(). Signed-off-by: David Howells <dhowells@redhat.com>
2013-04-09wlags49_h2: Don't use create_proc_entry()David Howells1-11/+0
create_proc_entry() shouldn't be used. Rather proc_create_data() should be used. The proc_write() function is only used by #if'd out code, so delete it for now. Signed-off-by: David Howells <dhowells@redhat.com>
2013-04-09nubus: Don't use create_proc_entry()David Howells1-2/+3
Don't use create_proc_entry() in nubus_proc_subdir(). The files created aren't given any way to use them, so for the moment use create_proc_read_entry() with a NULL accessor and generate a compile-time warning. Signed-off-by: David Howells <dhowells@redhat.com>
2013-04-09UM: Adjust printk in create_proc_mconsole()David Howells1-2/+1
Adjust printk in create_proc_mconsole() to reflect it is now using proc_create() not create_proc_mconsole(). Signed-off-by: David Howells <dhowells@redhat.com>