aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/ft1000 (follow)
AgeCommit message (Collapse)AuthorFilesLines
2010-11-09drivers/staging: delete double assignmentJulia Lawall1-1/+0
Delete successive assignments to the same location. In three of the cases, the two assignments are identical. In the case of the file rt2860/common/cmm_aes.c, the assigned variable i is never used, so both assignments are dropped. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression i; @@ *i = ...; i = ...; // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-19staging: ft1000: Remove FT1000_INFO typedef usage.Marek Belisko6-57/+57
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-19staging: ft1000: Remove dead code from ft1000_hw.cMarek Belisko1-262/+5
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-19staging: ft1000: Get rid of using typedef.Marek Belisko3-21/+21
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Use specific error return code for reg_ft1000_netdev().Marek Belisko3-5/+7
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Use specific return error codes.Marek Belisko1-13/+17
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Check return value when init net device.Marek Belisko1-1/+5
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Remove DRVMGS typedef usage.Marek Belisko3-9/+9
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Remove PSEUDO_HDR typedef usage.Marek Belisko5-63/+27
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Remove PROV_RECORD typedef usage.Marek Belisko3-11/+10
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Remove APP_INFO_BLOCK typedef usage.Marek Belisko1-14/+13
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Remove DSPINITMSG typedef usage.Marek Belisko2-15/+15
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Remove MEDIAMSG typedef usage.Marek Belisko2-5/+4
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15staging: ft1000: Remove unused function ft1000_hbchk()Marek Belisko1-147/+1
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15Staging: ft1000-usb: use the correct list headDan Carpenter1-1/+1
Using pdpram_blk here would cause an oops. We intended to use &freercvpool. Signed-off-by: Dan Carpenter <error27@gmail.com> Tested by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-15Staging: ft1000-usb: fix array overflowDan Carpenter1-2/+1
The code here is supposed checking if we exited the loop without hitting a break. The problem is that in the error handling "i" is out of bounds and it corrupts memory when we do an info->app_info[i].nRxMsgMiss++. >From the comments, it looks like someone noticed this corruption and updated the code, but didn't totally fix the problem. The correct fix is just to remove nRxMsgMiss++ from the error path. I believe this bug can be triggered remotely. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-14staging: ft1000: Use specific error return value.Marek Belisko1-26/+4
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-14staging: ft1000: Get rid of using atoi.Marek Belisko1-23/+13
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-14staging: ft1000: remove dead code.Marek Belisko1-77/+2
was #ifdef so remove code which was under #else to make code more readable. Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-14staging: ft1000: correct indentations for ft1000_usb.c file.Marek Belisko1-86/+79
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-14staging: ft1000: replace and remove c99 comments.Marek Belisko1-58/+9
Comments for probe, disconnect, init and exit functions removed completely (functions names are self explaining). Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-14staging: ft1000: lines over 80 characters corrected.Marek Belisko1-20/+43
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-14staging: ft1000: various checkpatch.pl fixes.Marek Belisko1-42/+29
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-12staging: ft1000: get rid of typedef usage.Marek Belisko1-32/+10
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-12staging: ft1000: Remove unused/unnecessary comments.Marek Belisko1-42/+8
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-12staging: ft1000: Fix memory leak when polling fail.Marek Belisko1-1/+2
Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-12staging: ft1000-usb: Remove global flag DSP_loading.Marek Belisko3-18/+13
This patch remove global flag DSP_loading which was checked only on one place. Instead check return value for dsp_reload() function. Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08Staging: ft1000:ft1000-pcmia: Makefile: replace the use of <module>-objs with <module>-yTracey Dent1-1/+1
Changed <module>-objs to <module>-y in Makefile. Signed-off-by: Tracey Dent <tdent48227@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08Staging: ft1000: ft1000-usb: Makefile: replace the use of <module>-objs with <module>-yTracey Dent1-1/+1
Changed <module>-objs to <module>-y in Makefile. Signed-off-by: Tracey Dent <tdent48227@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07staging: ft1000-usb: Add correct procedure for fw image downloading.Marek Belisko2-72/+26
call request_firmware instead of trying to open the file directly from the kernel driver. Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-05staging: ft1000: fix kernel info leak to userland for statisticsVasiliy Kulikov1-1/+1
get_stat_data is not fully initialized before copy_to_user() call, e.g. LedStat is not always set. Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-05staging: ft1000: fix error pathVasiliy Kulikov1-2/+19
init_ft1000_netdev() calls kfree(netdev) instead of free_netdev(netdev). It doesn't check kmalloc() return value. ft1000_read_fifo_reg() doesn't free dr on error and calls kfree(urb) instead of usb_free_urb(urb). Also kfree(NULL) is OK. Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-05staging/ft1000-usb: fix problems found by sparseArnd Bergmann6-120/+110
In the original code, address space annotations are missing, which hides a possible unchecked user pointer access. Two functions use a lot of stack space. Extern declarations are all in the wrong place, which leads to type differences between caller and callee in some cases. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-05staging/ft1000-usb: fix build warningsArnd Bergmann5-27/+33
This lets us see clearer when stuff breaks. Most of the changes are fixes for casts between int and pointer that don't work on 64 bit. The ioctl function uses a large amount of stack, which gets fixed by allocating the buffer dynamically. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-05staging/ft1000-usb: fix unlocked_ioctl prototypeArnd Bergmann1-2/+2
unlocked_ioctl has a "long" return type. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-05staging: make new character devices nonseekableArnd Bergmann1-4/+6
As a preparation for changing the default behaviour of llseek to no_llseek, every file_operations structure should have a .llseek operation. There are three new instances in staging now, which can all be changed into no_llseek explicitly since the devices do not need to seek. Add nonseekable_open where appropriate, to prevent pread/pwrite as well. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-09-30staging: ft1000: fix skb, netdev, memory leaksVasiliy Kulikov1-12/+20
ft1000_copy_up_pkt() doesn't free skb on errors. init_ft1000_card() doesn't free netdev with free_netdev() but with kfree(). init_ft1000_card() doesn't check request_region()'s return value and doesn't free region on error. Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-09-22Staging: ft1000: mark pcmcia driver brokenGreg Kroah-Hartman1-1/+1
The driver hasn't been updated since the .30 kernel release and will not build due to pcmcia api changes. Mark it broken for now so no one hits it in their build accidentally. Cc: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-09-22Staging: ft1000: fix mode of firmware image fileGreg Kroah-Hartman1-0/+0
It should not be executable. Cc: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-09-22Staging: ft1000: remove trailing whitespaceGreg Kroah-Hartman14-776/+776
Lots of trailing whitespace was removed Cc: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-09-22Staging: ft1000: fix buildGreg Kroah-Hartman2-7/+7
This fixes the build for the ft100-usb driver so it builds properly. Cc: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-09-22Staging: Add support for Flarion OFDM usb and pcmcia devices.Marek Belisko24-0/+11098
This drivers add support for following devices: (usb)-> Qleadtek FLASH-OFDM USB Modem [LR7F04] -> Qleadtek Express Card -> Leadtek Multi-band modem HSDPA Sources for usb: https://sourceforge.net/projects/ft1000/files/ft1000_usb/ft1000_usb_v01.04.tar.gz/download (pcmcia) -> Multimedia Net Card Sources for pcmcia : https://sourceforge.net/projects/ft1000/files/ft1000_pcmcia_2.6.30-2.6.31.tgz/download More informations (in Slovak language): http://ft1000.qintec.sk/home.html Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Copyright © 1996 – 2023 Jason A. Donenfeld. All Rights Reverse Engineered.