aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/otus (follow)
AgeCommit message (Collapse)AuthorFilesLines
2010-08-02Staging: comedi : fix brace coding style issue in wwrap.cDaniele Boncompagni1-522/+446
This is a patch to the wwrap.c file that fixes up a brace warnings and other errors found by the checkpatch.pl tool. Signed-off-by: Daniele Boncompagni <daniele.boncompagni@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-02staging: otus: check kmalloc() return valueKulikov Vasiliy1-0/+5
kmalloc() may fail, if so return error from zfwUsbSubmitControl(). Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-22Staging: fix typos concerning "address"Uwe Kleine-König1-1/+1
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-22staging: otus: remove unused methodsAndy Shevchenko1-22/+0
This is rebased version of the patch [1] which was mysteriously not pushed anywhere but acked. Here are two methods to convert hex value to binary format. These certain methods aren't used anywhere in kernel. [1] http://lkml.org/lkml/2010/2/18/267 Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-08Staging: otus: wrap_sec: remove casts from void*Kulikov Vasiliy1-1/+1
Remove unnesessary casts from void*. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-08Staging: otus: use ARRAY_SIZEKulikov Vasiliy1-18/+10
Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x). Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-08Staging: otus: use ARRAY_SIZEKulikov Vasiliy1-10/+7
Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x). Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-08Staging: otus: use ARRAY_SIZEKulikov Vasiliy1-10/+6
Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x). Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-08Staging: otus: fix coding style issues in ioctl.cGustavo Silva1-30/+23
This is a patch to the ioctl.c file that fixes up the following issues: ERROR: that open brace { should be on the previous line x 3 WARNING: please, no space before tabs x 1 ERROR: space required before the open parenthesis '(' x 5 WARNING: braces {} are not necessary for single statement blocks x 2 ERROR: space prohibited after that '!' (ctx:BxW) x 1 WARNING: suspect code indent for conditional statements x 2 ERROR: do not use C99 // comments x 1 WARNING: braces {} are not necessary for any arm of this statement x 4 Signed-off-by: Gustavo Silva <silvagustavo@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-06-18Staging: otus: Removed one unnecessary spaceMatti Lammi1-1/+1
Nothing special really, just a small fix. Signed-off-by: Matti Lammi <matti.lammi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-06-18Staging: otus: fix strcpy() overflowDan Carpenter1-1/+1
wrq->name is only 16 characters long but "IEEE 802.11-MIMO" is 16 characters + a NULL character, so it's too long. This patch changes it to "IEEE 802.11abgn". Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-06-18Staging: otus: TODO: Don't bother, for documentation purposes onlyJoe Perches1-12/+4
On Mon, 2010-06-07 at 12:02 -0700, Luis R. Rodriguez wrote: > this driver is unmaintained and its only purpose is as a > source of documentation for developers working on ar9170 and carl9170. > Once carl9170 gets 11n support and merged upstream then this driver > can be removed. Then the TODO file should be updated. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-06-18Staging: otus: fix style issues in zdusb.cScott Kidder1-132/+119
This is a patch to zdusb.c that fixes whitespace, C99 comment, and other style issues found by the checkpatch.pl tool Signed-off-by: Scott Kidder <scott.kidder11@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-14Staging: Use kcalloc or kzallocJulia Lawall1-4/+1
Use kcalloc or kzalloc rather than the combination of kmalloc and memset. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y,flags; statement S; type T; @@ x = - kmalloc + kcalloc ( - y * sizeof(T), + y, sizeof(T), flags); if (x == NULL) S -memset(x, 0, y * sizeof(T)); @@ expression x,size,flags; statement S; @@ -x = kmalloc(size,flags); +x = kzalloc(size,flags); if (x == NULL) S -memset(x, 0, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk>
2010-05-11Staging: otus: Hoist assign from ifJoe Perches3-15/+24
Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: 80211core: Hoist assign from ifJoe Perches13-178/+339
Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: Add null check and fix coding style issuePeter Huewe1-2/+5
This patch removes mixing of declarations and code and adds a null-test after a kmalloc. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: Otus: Hal: hpani.c Fixed some style issuesVikram Dhillon1-19/+14
Fixed some style issues in accordance with checkpatch.pl Signed-by: Vikram Dhillon <opensolarisdev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpani: using the wrong variableDan Carpenter1-1/+1
We're updating the "HpPriv->ani" array here so we should use that to determine the end of the for loop. "HpPriv->ani" has 50 elements and "wd->regulationTable.allowChannel" has 59 elements. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: Remove mix of tabs and spaces with just tabs in ioctl.cSteven Harms1-15/+15
Previously defines had a mix of both tabs and spaces, causing an error in the checkpatch tool. These tabs and spaces have been consolidated to only tabs. Signed-off-by: Steven Harms <sharms@ubuntu.com> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: drop redundant memsetJulia Lawall1-1/+0
The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpfwu_BA.c: Checkpatch cleanupAndrea Gelmini1-1/+1
drivers/staging/otus/hal/hpfwu_BA.c:874: ERROR: spaces required around that '=' (ctx:VxV) Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpreg.c: Checkpatch cleanupAndrea Gelmini1-832/+754
drivers/staging/otus/hal/hpreg.c:33: WARNING: space prohibited between function name and open parenthesis '(' drivers/staging/otus/hal/hpreg.c:33: WARNING: space prohibited between function name and open parenthesis '(' drivers/staging/otus/hal/hpreg.c:38: CHECK: if this code is redundant consider removing it drivers/staging/otus/hal/hpreg.c:81: ERROR: need consistent spacing around '|' (ctx:VxW) drivers/staging/otus/hal/hpreg.c:96: ERROR: Macros with multiple statements should be enclosed in a do - while loop drivers/staging/otus/hal/hpreg.c:98: CHECK: if this code is redundant consider removing it drivers/staging/otus/hal/hpreg.c:275: ERROR: need consistent spacing around '|' (ctx:WxV) drivers/staging/otus/hal/hpreg.c:304: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:362: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:376: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:377: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:402: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:402: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:413: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:413: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:434: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:496: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:497: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:501: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:526: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:529: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:531: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:539: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:539: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:544: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:663: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1335: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1336: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1345: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1345: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1346: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1346: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1347: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1347: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1357: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1357: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1367: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1367: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1377: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1377: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1378: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1378: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1387: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1387: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1388: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1388: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1397: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1397: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1407: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1407: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1408: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1408: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1432: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1432: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1432: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1435: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1435: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1435: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1436: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1436: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1436: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1442: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1442: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1442: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1445: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1445: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1445: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1446: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1446: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1446: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required before that '-' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1557: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1558: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1560: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '<' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '&&' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1562: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1568: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1574: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1579: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1590: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1590: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1590: ERROR: space required after that ';' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1590: ERROR: spaces required around that '<' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1592: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1594: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1613: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1613: ERROR: spaces required around that '<' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1635: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:1639: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1639: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1640: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:1643: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1647: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1647: WARNING: suspect code indent for conditional statements (8, 8) drivers/staging/otus/hal/hpreg.c:1649: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1652: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1652: WARNING: suspect code indent for conditional statements (8, 8) drivers/staging/otus/hal/hpreg.c:1654: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1657: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1659: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1660: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1662: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1662: ERROR: else should follow close brace '}' drivers/staging/otus/hal/hpreg.c:1664: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1671: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1674: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1675: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1676: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1676: ERROR: space required after that ',' (ctx:VxO) drivers/staging/otus/hal/hpreg.c:1676: ERROR: space required before that '*' (ctx:OxV) drivers/staging/otus/hal/hpreg.c:1676: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1678: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1681: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1682: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1682: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1683: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1684: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1685: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1686: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1687: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1690: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1692: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1693: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1694: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1695: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1695: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1696: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1696: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1697: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1697: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1698: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1698: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1699: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1700: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1700: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1701: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1702: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1702: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1703: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1706: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1707: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1708: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1710: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1711: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1712: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1713: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1714: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1714: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1717: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1719: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1720: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1721: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1722: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1722: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1723: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1723: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1724: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1724: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1725: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1725: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1726: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1726: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1727: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1728: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1728: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1729: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1730: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1730: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1731: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1734: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1735: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1735: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1736: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1737: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1738: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1739: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1740: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1743: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1744: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1744: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1745: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1746: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1747: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1748: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1749: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1752: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1755: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1755: WARNING: suspect code indent for conditional statements (16, 20) drivers/staging/otus/hal/hpreg.c:1757: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1759: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1760: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1760: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1761: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1762: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1762: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1763: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1764: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1766: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1766: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1767: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1767: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1767: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:1767: ERROR: space prohibited before that close parenthesis ')' drivers/staging/otus/hal/hpreg.c:1768: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1769: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1770: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1772: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1772: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1772: ERROR: space required after that ';' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1772: ERROR: spaces required around that '<' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1774: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1774: ERROR: space required after that ',' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1778: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1779: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1780: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1781: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1781: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1786: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1786: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1787: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1787: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1787: ERROR: spaces required around that '==' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1788: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1789: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1789: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1789: ERROR: space prohibited after that open parenthesis '(' drivers/staging/otus/hal/hpreg.c:1789: ERROR: space prohibited before that close parenthesis ')' drivers/staging/otus/hal/hpreg.c:1789: ERROR: space required before the open parenthesis '(' drivers/staging/otus/hal/hpreg.c:1790: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1791: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1792: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1793: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1794: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1795: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1796: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1797: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1798: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1799: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1799: WARNING: suspect code indent for conditional statements (40, 44) drivers/staging/otus/hal/hpreg.c:1805: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1807: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1809: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1811: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1814: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1816: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1817: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1820: ERROR: space required before the open parenthesis '(' drivers/staging/otus/hal/hpreg.c:1821: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1826: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1837: CHECK: if this code is redundant consider removing it drivers/staging/otus/hal/hpreg.c:1839: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1840: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1841: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1842: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1843: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1845: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1845: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1845: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:1845: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1845: ERROR: spaces required around that '<' (ctx:VxV) drivers/staging/otus/hal/hpreg.c:1846: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1847: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1848: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1849: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1850: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1851: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1852: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1853: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1854: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1861: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:1863: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1871: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:1874: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1881: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1883: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1883: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1883: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:1884: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1885: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1887: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1887: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1888: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1888: ERROR: "(foo*)" should be "(foo *)" drivers/staging/otus/hal/hpreg.c:1890: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1890: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1892: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1892: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1893: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1894: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1894: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1896: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1897: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1898: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1899: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1904: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:1908: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1909: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1915: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1916: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1917: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1917: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1919: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1920: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1922: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1922: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1923: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1923: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1923: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:1924: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1925: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1925: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1926: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1926: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1928: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1930: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1930: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1931: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1932: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1933: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1935: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1935: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1936: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1936: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1937: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1937: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1938: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1938: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1939: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1939: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1940: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1940: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1941: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1941: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1942: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1942: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1943: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1943: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1944: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1944: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1945: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1945: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1946: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1946: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1947: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1947: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1948: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1948: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1949: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1949: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1950: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1950: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1951: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1951: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1952: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1952: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1953: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1953: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1954: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1954: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1955: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1955: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1956: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1956: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1957: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1957: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1958: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1958: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1959: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1959: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1960: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1960: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1961: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1961: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1962: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1962: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1963: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1963: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1964: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1964: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1965: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1965: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1966: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1966: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1967: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1967: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1968: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1968: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1969: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1969: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1970: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1970: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1971: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1971: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1973: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1974: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1976: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:1980: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:1984: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1986: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1986: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:1986: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:1987: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1988: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1989: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:1995: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2003: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2005: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2005: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2005: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2006: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2007: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2008: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2009: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2032: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2035: ERROR: space required after that close brace '}' drivers/staging/otus/hal/hpreg.c:2039: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2041: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2041: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2042: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2045: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2047: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2048: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2050: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2050: ERROR: else should follow close brace '}' drivers/staging/otus/hal/hpreg.c:2052: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2055: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2057: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2057: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2057: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2058: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2059: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2060: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2061: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2061: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2062: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2063: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2064: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2065: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2066: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2067: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2073: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2079: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2081: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2081: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2082: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2085: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2085: ERROR: space prohibited after that open parenthesis '(' drivers/staging/otus/hal/hpreg.c:2087: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2087: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2087: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2088: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2089: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2090: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2091: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2093: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2093: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2094: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2094: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2096: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2098: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2098: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2098: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2099: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2100: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2101: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2102: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2103: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2105: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2111: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2117: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2119: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2119: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2120: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2120: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2120: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2121: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2122: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2123: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2124: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2127: ERROR: return is not a function, parentheses are not required drivers/staging/otus/hal/hpreg.c:2130: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2140: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2142: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2142: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2143: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2143: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2143: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2144: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2145: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2146: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2147: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2152: ERROR: return is not a function, parentheses are not required drivers/staging/otus/hal/hpreg.c:2155: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2160: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2162: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2162: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2162: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2163: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2164: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2165: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2171: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2181: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2183: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2183: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2183: WARNING: suspect code indent for conditional statements (8, 12) drivers/staging/otus/hal/hpreg.c:2184: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2185: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2185: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2186: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2187: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2187: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2187: WARNING: suspect code indent for conditional statements (16, 20) drivers/staging/otus/hal/hpreg.c:2188: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2189: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2190: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2191: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2192: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2193: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2193: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2193: ERROR: else should follow close brace '}' drivers/staging/otus/hal/hpreg.c:2194: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2195: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2195: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2195: WARNING: suspect code indent for conditional statements (16, 20) drivers/staging/otus/hal/hpreg.c:2196: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2197: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2198: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2199: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2200: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2201: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2212: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2216: ERROR: that open brace { should be on the previous line drivers/staging/otus/hal/hpreg.c:2218: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2219: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2220: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2221: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2222: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2223: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2224: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2225: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2226: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2227: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2228: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2229: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2230: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2231: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2232: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2233: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2234: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2235: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2235: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2236: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2238: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2239: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2239: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2240: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2242: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2243: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2244: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2245: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2246: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2247: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2248: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2249: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2250: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2251: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2252: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2253: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2254: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2255: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2256: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2257: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2258: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2259: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2260: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2260: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2261: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2263: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2264: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2265: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2266: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2267: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2268: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2269: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2270: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2271: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2272: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2273: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2274: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2275: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2276: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2277: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2278: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2279: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2280: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2281: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2282: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2283: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2284: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2285: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2286: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2287: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2288: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2289: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2290: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2291: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2292: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2293: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2294: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2295: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2296: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2297: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2298: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2299: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2300: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2301: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2302: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2303: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2304: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2305: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2306: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2307: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2308: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2309: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2310: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2311: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2312: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2313: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2314: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2315: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2316: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2317: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2318: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2319: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2320: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2321: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2322: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2323: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2324: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2325: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2326: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2327: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2328: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2329: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2330: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2331: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2332: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2332: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2333: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2335: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2336: ERROR: code indent should use tabs where possible drivers/staging/otus/hal/hpreg.c:2338: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpreg.c:2343: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2345: ERROR: "foo* bar" should be "foo *bar" drivers/staging/otus/hal/hpreg.c:2348: ERROR: spaces required around that '=' (ctx:VxV) Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpfw2.c: Checkpatch cleanupAndrea Gelmini1-1/+1
drivers/staging/otus/hal/hpfw2.c:1018: ERROR: spaces required around that '=' (ctx:VxV) Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpfwu_OTUS_RC.c: Checkpatch cleanupAndrea Gelmini1-1/+1
drivers/staging/otus/hal/hpfwu_OTUS_RC.c:715: ERROR: spaces required around that '=' (ctx:VxV) Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpani.h: Checkpatch cleanupAndrea Gelmini1-4/+3
drivers/staging/otus/hal/hpani.h:102: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpani.h:356: ERROR: do not use C99 // comments drivers/staging/otus/hal/hpani.h:395: ERROR: do not use C99 // comments Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpfwu_2k.c: Checkpatch cleanupAndrea Gelmini1-1/+1
drivers/staging/otus/hal/hpfwu_2k.c:1016: ERROR: spaces required around that '=' (ctx:VxV) Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpfwu.c: Checkpatch cleanupAndrea Gelmini1-1/+1
drivers/staging/otus/hal/hpfwu.c:1017: ERROR: spaces required around that '=' (ctx:VxV) Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11Staging: otus: hpfwuinit.c: Checkpatch cleanupAndrea Gelmini1-1/+1
drivers/staging/otus/hal/hpfwuinit.c:240: ERROR: spaces required around that '=' (ctx:VxV) Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-04-05staging/otus: include slab.h from usbdrv.hTejun Heo1-0/+1
drivers/staging/otus/usbdrv.h users use slab facilities. Include linux/slab.h from usbdrv.h. Signed-off-by: Tejun Heo <tj@kernel.org>
2010-03-30include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.hTejun Heo7-0/+7
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-03Staging: otus: fix memory leakd binderman1-3/+3
Fix memory leak in drivers/staging/otus Signed-off-by: David Binderman <dcb314@hotmail.com>
2010-03-03staging: fix typos "enalbe" -> "enable"Uwe Kleine-König1-1/+1
This patch was generated by git grep -E -l 'enalbe' drivers/staging | xargs -r perl -p -i -e 's/enalbe/enable/g' Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: fix assignment makes integer from pointer without a cast warningsJeff Mahoney2-10/+4
This patch fixes some %x pointer printing to %p. It also uses the skb_tail_pointer and skb_mac_header macros for accessing thos members. Signed-off-by: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03staging: make USB device id constantNémeth Márton1-1/+1
The id_table field of the struct usb_device_id is constant in <linux/usb.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Németh Márton <nm127@freemail.hu> Cc: Julia Lawall <julia@diku.dk> Cc: cocci@diku.dk Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: zfTkipInit(): increment another pointerSimon Horman1-2/+3
Increment the pointer rather than its value. These appear to be logic errors. Thanks to Dan Carpenter for the first hunk of this change. Cc: Dan Carpenter <error27@gmail.com> Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: Fix ZM_SEQ_DEBUG macro for no-debug casehorms@vergenet.net2-7/+9
tcp_seq is only initialised in case where ZM_ENABLE_PERFORMANCE_EVALUATION is defined. So move the call to ZM_SEQ_DEBUG() and the decleration of tcp_seq in there too. This allows ZM_SEQ_DEBUG() to be removed from the non-ZM_ENABLE_PERFORMANCE_EVALUATION case in the header file. This resolves several compile warnings for the non-ZM_ENABLE_PERFORMANCE_EVALUATION case. However, the ZM_ENABLE_PERFORMANCE_EVALUATION case seems to be completely broken. $ gcc (Debian 4.4.2-8) 4.4.2 Copyright (C) 2009 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ make ... drivers/staging/otus/80211core/cagg.c: In function 'zfAggRxEnabled': drivers/staging/otus/80211core/cagg.c:1872: warning: left-hand operand of comma expression has no effect drivers/staging/otus/80211core/cagg.c:1872: warning: left-hand operand of comma expression has no effect drivers/staging/otus/80211core/cagg.c:1872: warning: statement with no effect ... Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: remove unused constantshorms@vergenet.net1-133/+0
Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: remove unused variableshorms@vergenet.net10-28/+1
Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: dont mix declarations and codehorms@vergenet.net1-3/+5
$ gcc (Debian 4.4.2-8) 4.4.2 Copyright (C) 2009 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ make ... drivers/staging/otus/ioctl.c: In function 'usbdrv_wpa_ioctl': drivers/staging/otus/ioctl.c:2253: warning: ISO C90 forbids mixed declarations and code ... Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: Add select WEXT_PRIV to Kconfig to prevent build failurePeter Huewe1-0/+2
Without WEXT_PRIV set the driver fails to build due to unknown fields in the iw_handler_def struct. Those fields are enclosed in WEXT_PRIV conditionals in the prototype of iw_handler_def in include/net/iw_handler.h Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: 80211core: Fix &&/|| confusionRoel Kluin1-1/+1
This always evaluates to true. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: off by one in usbdrvwext_siwessid()Dan Carpenter1-1/+1
A 33 char ESSID is too long and it could cause a buffer overflow a couple lines below when we put a NULL terminator on the end. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: Fix branch in zfProtRspSim()Roel Kluin1-2/+1
This semicolon is misplaced. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-03Staging: otus: fix some sparse warningsThiago Farina1-28/+25
*apdbg.c: use NULL pointer instead of 0 interger. Also make two functions private. Signed-off-by: Thiago Farina <tfransosi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11Staging: fix assorted typos all over the placeAndré Goddard Rosa5-8/+8
Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11Staging: otus : checkpatch.pl cleanup for some more .c filesMithlesh Thukral7-510/+502
Second lot of checkpatch.pl error and warning fixes for .c files of otus driver in staging tree. (Externs would be removed in a seperate patch) Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11Staging: otus : checkpatch.pl cleanup for .c filesMithlesh Thukral3-434/+384
First patch for checkpatch.pl error and warning fixes for .c files of otus driver in staging tree. Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-11Staging: otus : checkpatch.pl cleanup for header filesMithlesh Thukral5-122/+126
Fix for checkpatch.pl errors and warnings in header files of otus driver. (There is a typedef which still remains. Plan to clean it up in next set of patches) Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-04tree-wide: fix misspelling of "definition" in commentsAdam Buchbinder2-2/+2
"Definition" is misspelled "defintion" in several comments; this patch fixes them. No code changes. Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Copyright © 1996 – 2023 Jason A. Donenfeld. All Rights Reverse Engineered.