aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging
AgeCommit message (Collapse)AuthorFilesLines
2021-10-16scsi: staging: unisys: visorhba: Call scsi_done() directlyBart Van Assche1-8/+6
Conditional statements are faster than indirect calls. Hence call scsi_done() directly. Link: https://lore.kernel.org/r/20211007204618.2196847-8-bvanassche@acm.org Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2021-10-16scsi: staging: rts5208: Call scsi_done() directlyBart Van Assche1-3/+2
Conditional statements are faster than indirect calls. Hence call scsi_done() directly. Link: https://lore.kernel.org/r/20211007204618.2196847-7-bvanassche@acm.org Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2021-10-15staging: wlan-ng: Avoid bitwise vs logical OR warning in hfa384x_usb_throttlefn()Nathan Chancellor1-11/+11
A new warning in clang points out a place in this file where a bitwise OR is being used with boolean expressions: In file included from drivers/staging/wlan-ng/prism2usb.c:2: drivers/staging/wlan-ng/hfa384x_usb.c:3787:7: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical] ((test_and_clear_bit(THROTTLE_RX, &hw->usb_flags) && ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/wlan-ng/hfa384x_usb.c:3787:7: note: cast one or both operands to int to silence this warning 1 warning generated. The comment explains that short circuiting here is undesirable, as the calls to test_and_{clear,set}_bit() need to happen for both sides of the expression. Clang's suggestion would work to silence the warning but the readability of the expression would suffer even more. To clean up the warning and make the block more readable, use a variable for each side of the bitwise expression. Link: https://github.com/ClangBuiltLinux/linux/issues/1478 Signed-off-by: Nathan Chancellor <nathan@kernel.org> Link: https://lore.kernel.org/r/20211014215703.3705371-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-15staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.cPhillip Potter1-6/+0
Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve no purpose other than to print the name of the function they are in (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the function, which is better accomplished by other means. Also remove the jiffies assignment at the start of the function, as it is no longer used. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20211015000233.842-1-phil@philpotter.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: vt6655: fix camelcase in byRateTommaso Merciai1-3/+3
Replace camel case function parameter name byRate (hungarian notation) with snake case equivalent, in card.c Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211007161535.7563-1-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: ks7010: select CRYPTO_HASH/CRYPTO_MICHAEL_MICVegard Nossum1-0/+3
Fix the following build/link errors: ld: drivers/staging/ks7010/ks_hostif.o: in function `michael_mic.constprop.0': ks_hostif.c:(.text+0x95b): undefined reference to `crypto_alloc_shash' ld: ks_hostif.c:(.text+0x97a): undefined reference to `crypto_shash_setkey' ld: ks_hostif.c:(.text+0xa13): undefined reference to `crypto_shash_update' ld: ks_hostif.c:(.text+0xa28): undefined reference to `crypto_shash_update' ld: ks_hostif.c:(.text+0xa48): undefined reference to `crypto_shash_finup' ld: ks_hostif.c:(.text+0xa6d): undefined reference to `crypto_destroy_tfm' Fixes: 8b523f20417d ("staging: ks7010: removed custom Michael MIC implementation.") Fixes: 3e5bc68fa5968 ("staging: ks7010: Fix build error") Fixes: a4961427e7494 ("Revert "staging: ks7010: Fix build error"") Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com> Link: https://lore.kernel.org/r/20211011152941.12847-1-vegard.nossum@oracle.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: fbtft: Make fbtft_remove_common() return voidUwe Kleine-König2-10/+6
fbtft_remove_common() is only called with a non-NULL fb_info. (All callers are in remove callbacks and the matching probe callbacks set driver data accordingly.) So fbtft_remove_common() always returns zero. Make it return void instead which makes it easier to see in the callers that there is no error to handle. Also the return value of platform and spi remove callbacks is ignored anyway and not freeing resources in .remove() is a bad idea. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20211012153945.2651412-20-u.kleine-koenig@pengutronix.de Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: Use zeroing allocator in wpa_set_encryption()Gustavo A. R. Silva1-2/+1
Use zeroing allocator rather than allocator followed by memset with 0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20211012024624.GA1062447@embeddedor Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: Fix misspelling in commentSiou-Jhih, Guo1-1/+1
As format check raised by scripts/checkpatch.pl, comment in the rtw_ap.c looks misspelled by accident. Help fix it. The original error is as below shows: CHECK: 'followign' may be misspelled - perhaps 'following'? +Set to 0 (HT pure) under the followign conditions Signed-off-by: Siou-Jhih, Guo <hallblazzar@gmail.com> Link: https://lore.kernel.org/r/20211011214803.GA239300@hallblazzar-Precision-5510 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: most: dim2: use device release methodNikita Yushchenko1-25/+30
Commit 723de0f9171e ("staging: most: remove device from interface structure") moved registration of driver-provided struct device to the most subsystem. This updated dim2 driver as well. However, struct device passed to register_device() becomes refcounted, and must not be explicitly deallocated, but must provide release method instead. Which is incompatible with managing it via devres. This patch makes the device structure allocated without devres, adds device release method, and moves device destruction there. Fixes: 723de0f9171e ("staging: most: remove device from interface structure") Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Link: https://lore.kernel.org/r/20211005143448.8660-2-nikita.yoush@cogentembedded.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: most: dim2: do not double-register the same deviceNikita Yushchenko4-72/+14
Commit 723de0f9171e ("staging: most: remove device from interface structure") moved registration of driver-provided struct device to the most subsystem. Dim2 used to register the same struct device to provide a custom device attribute. This causes double-registration of the same struct device. Fix that by moving the custom attribute to driver's dev_groups. This moves attribute to the platform_device object, which is a better location for platform-specific attributes anyway. Fixes: 723de0f9171e ("staging: most: remove device from interface structure") Acked-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Link: https://lore.kernel.org/r/20211011061117.21435-1-nikita.yoush@cogentembedded.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: odm SupportPlatform is always ODM_CEMartin Kaiser8-158/+19
Remove the SupportPlatform entry of struct odm_dm_struct and any code that depends on SupportPlatform != ODM_CE. Merge functions in places where there was a "top-level function" that would select a "sub-function" based on SupportPlatform. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-9-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: odm BoardType is never setMartin Kaiser6-36/+1
odm BoardType is never set, so it's always 0 (ODM_BOARD_NORMAL). Remove dead code and the BoardType itself. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-8-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm_SwAntDivInitMartin Kaiser2-7/+0
This function is empty, it can be removed. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-7-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: SupportICType is always ODM_RTL8188EMartin Kaiser5-184/+68
SupportICType in struct odm_dm_struct is always ODM_RTL8188E. Remove the component and code that is executed only for other types. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-6-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove LastMinUndecoratedPWDBForDMMartin Kaiser1-1/+0
LastMinUndecoratedPWDBForDM in struct dm_priv is not used. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-5-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove rtl8188e_deinit_dm_privMartin Kaiser3-7/+0
This function is empty and can be removed. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-4-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: simplify rtl8188e_HalDmWatchDogMartin Kaiser1-30/+13
Now that we don't call dm_CheckStatistics any more, we don't need fw_cur_in_ps and fw_ps_awake. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-3-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove dm_CheckStatisticsMartin Kaiser1-11/+0
The dm_CheckStatistics function is empty. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211011201159.10252-2-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm ext lna infoMartin Kaiser2-9/+1
The ext lna info is never set. Remove it and fix up the one place where it's read. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-11-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm ext pa infoMartin Kaiser2-6/+0
The ext pa info is not used. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-10-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm ext trsw infoMartin Kaiser2-6/+0
The ext trsw info is not used. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-9-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm hct test infoMartin Kaiser3-6/+1
The "in hct test" variable is never set, it's always 0. Remove the variable and fix up the one place where it was used. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-8-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm wifi test infoMartin Kaiser3-7/+0
The wifi test info is set but not used. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-7-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm dualmac smart concurrent infoMartin Kaiser2-5/+0
The dualmac smart concurrent info is set but not used. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-6-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm cut version infoMartin Kaiser3-22/+0
The cut version info is set but not used. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-5-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove odm fab version infoMartin Kaiser3-15/+1
The fab version info is set but not used. Remove it. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-4-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: RfOnOffDetect is unusedMartin Kaiser2-20/+0
Remove the RfOnOffDetect function, which is not used. Suggested-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-3-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove specific device tableMartin Kaiser2-42/+0
This driver implements a mechanism to set additional configuration flags per supported usb device. None of the supported devices uses these additional flags. Remove the data types and the code to process the flags. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-2-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: r8188eu: remove an unused defineMartin Kaiser1-2/+0
_HCI_INTF_C_ is not used and can be removed. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211010175204.24029-1-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-13staging: vt6655: fix camelcase in byLocalIDTommaso Merciai10-13/+13
Replace camel case variable name for variable byLocalID with snake case equivalent. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211010220014.148785-1-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: rtl8723bs: hal: remove duplicate checkSaurav Girepunje1-1/+1
Remove 'bPerformance' from if condition check. As on previous if condition it is already check for same variable. Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YWKRfYpTioAmTWa0@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove enum _RTL8712_RF_MIMO_CONFIG_Michael Straube1-11/+0
The enum _RTL8712_RF_MIMO_CONFIG_ is not used, remove it. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211009104419.8811-3-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: replace MACADDRLEN with ETH_ALENMichael Straube3-27/+26
Replace the custom constant MACADDRLEN with in-kernel ETH_ALEN. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211009104419.8811-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove unused macros and defines from rtl8188e_hal.hMichael Straube1-55/+0
Remove unused macros and defines from rtl8188e_hal.h. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211009104419.8811-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove some dead codeMichael Straube2-72/+1
In this driver SupportICType is ODM_RTL8188E and SupportInterface is ODM_ITRF_USB. Remove an if statement that is never true and remove function odm_DIGbyRSSI_LPS() which is used only in this dead if block. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211008172621.8721-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove unused defines from rtw_sreset.hMichael Straube1-4/+0
Remove unused defines from rtw_sreset.h. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211008100209.28801-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: rename rtl8188eu_set_hal_ops()Michael Straube3-4/+4
After the removal of struct hal_ops function rtl8188eu_set_hal_ops() only allocates memory for adapt->HalData. Rename the function to rtl8188eu_alloc_haldata() to reflect what it actually does. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211007103943.8433-6-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove hal_opsMichael Straube4-11/+3
Remove the last pointer hal_deinit from struct hal_ops and call rtl8188eu_hal_deinit() directly. Remove the now empty struct hal_ops. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211007103943.8433-5-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove hal_init from hal_opsMichael Straube3-4/+4
Remove hal_init from struct hal_ops and call rtl8188eu_hal_init() directly. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211007103943.8433-4-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove GetHwRegHandler from hal_opsMichael Straube14-28/+17
Remove GetHwRegHandler from struct hal_ops and remove the wrapper rtw_hal_get_hwreg(). Call GetHwReg8188EU() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211007103943.8433-3-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove SetHwRegHandler from hal_opsMichael Straube14-101/+78
Remove SetHwRegHandler from struct hal_ops and remove the wrapper rtw_hal_set_hwreg(). Call SetHwReg8188EU() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20211007103943.8433-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: merge two signal scale mapping functionsMartin Kaiser1-6/+1
Keep the odm_SignalScaleMapping function and remove odm_SignalScaleMapping_92CSeries. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211006090949.1694-4-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: Odm PatchID is always 0Martin Kaiser4-50/+16
PatchID is a copy of the hal customer id that is always 0. Remove PatchID from struct odm_dm_struct and the code that is executed only for PatchID != 0. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211006090949.1694-3-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: hal data's customer id is always 0Martin Kaiser4-59/+2
CustomerID in struct hal_data_8188e is never set, it remains at the default value 0. Remove CustomerID and fix the two places where it was used. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211006090949.1694-2-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: support interface is always usbMartin Kaiser1-39/+19
We set ODM_CMNINFO_INTERFACE to ODM_ITRF_USB as this driver supports only usb. Therefore, dm_odm->SupportInterface is always ODM_ITRF_USB. Simplify some if conditions accordingly. Remove/replace two empty functions. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-9-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: interface type is always usbMartin Kaiser4-15/+1
This driver only supports chips that connect via usb. Remove interface_type from struct adapter, use a constant in the one place where the interface type is needed. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-8-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: chip_type is write-onlyMartin Kaiser5-27/+0
chip_type in struct adapter is never read. Remove the component and the code to initialise it. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-7-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: HardwareType is write-onlyMartin Kaiser3-4/+0
HardwareType in struct adapter is never read, it can be removed. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-6-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove two write-only hal componentsMartin Kaiser2-5/+0
RegTxPause and RegBcnCtrlVal from struct hal_data_8188e are set but never read. Remove them. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-5-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Copyright © 1996 – 2026 Jason A. Donenfeld. All Rights Reverse Engineered.