aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging
AgeCommit message (Collapse)AuthorFilesLines
2021-10-10staging: r8188eu: remove unused IntrMaskMartin Kaiser2-4/+0
The IntrMask array is set but never read. Remove it. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-4-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove write-only HwRxPageSizeMartin Kaiser3-25/+0
HwRxPageSize from struct hal_data_8188e is set but never read. Remove the component and the code to initialise it. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-3-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove unused led componentMartin Kaiser1-2/+0
bSWLedCtrl in struct LED_871x is not used. Remove it. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-2-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: r8188eu: remove an obsolete commentMartin Kaiser1-15/+0
The function that this comment describes is not present in the r8188eu driver. The comment can be removed. Signed-off-by: Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20211005200821.19783-1-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: vt6655: fix camelcase in PortOffsetTommaso Merciai9-172/+172
Replace camel case variable PortOffset with snake case variable port_offset. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-4-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: vt6655: fix camelcase in ldBmThresholdTommaso Merciai3-26/+26
Replace camel case variable ldBmThreshold with snake case variable dbm_threshold. ldBmThreshold is in hungarian notation, where "l" is for long and "dbm" is for decibel-milliwatt (signal strenght). This variable contain's signal strenght threshold in dbm. References: - https://en.wikipedia.org/wiki/Hungarian_notation - https://www.rapidtables.com/electric/dBm.html Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-3-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-10staging: vt6655: fix camelcase in bShortSlotTimeTommaso Merciai4-6/+6
Replace camel case variable bShortSlotTime with snake case variable short_slot_time. bShortSlotTime is a boolean variable, if true short slot time is enabled, false not. Short Slot Time reduces the slot time from 20 microseconds to 9 microseconds, where the slot time is the maximum theoretical time for a frame to travel a network. References: - http://cciew.blogspot.com/2011/02/short-slot-time.html - https://www.cse.wustl.edu/~jain/cse574-16/ftp/j_05lan4.pdf - https://www.networkdatapedia.com/post/2013/09/16/ \ configuring-short-slot-time-to-improve-wifi-performance - https://en.wikipedia.org/wiki/Slot_time Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-2-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-08media: ipu3-imgu: VIDIOC_QUERYCAP: Fix bus_infoRicardo Ribalda1-2/+3
bus_info field had a different value for the media entity and the video device. Fixes v4l2-compliance: v4l2-compliance.cpp(637): media bus_info 'PCI:0000:00:05.0' differs from V4L2 bus_info 'PCI:viewfinder' Reviewed-by: Bingbu Cao <bingbu.cao@intel.com> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-08media: ipu3-imgu: imgu_fmt: Handle properly tryRicardo Ribalda1-1/+1
For a try_fmt call, the node noes not need to be enabled. Fixes v4l2-compliance fail: v4l2-test-formats.cpp(717): Video Output Multiplanar is valid, but no TRY_FMT was implemented test VIDIOC_TRY_FMT: FAIL Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-08media: ipu3-imgu: Set valid initial formatRicardo Ribalda1-1/+3
The initial format did not have a valid size. Fixes v4l2-compliance: fail: v4l2-test-formats.cpp(723): Video Output Multiplanar: TRY_FMT(G_FMT) != G_FMT test VIDIOC_TRY_FMT: FAIL Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-08media: ipu3-imgu: Refactor bytesperpixel calculationRicardo Ribalda3-17/+15
Move the calculation to an inline function, to it can be used by other parts of the driver. Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-08media: staging/intel-ipu3: Constify static struct v4l2_subdev_internal_opsRikard Falkeborn1-1/+1
The only usage of imgu_subdev_internal_ops is to assign its address to the internal_ops field in the v4l2_subdev struct, which is a pointer to const v4l2_subdev_internal_ops. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-07Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/netJakub Kicinski1-0/+2
No conflicts. Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2021-10-05staging: mt7621-dts: properly define 'cpc' and 'mc' nodesSergio Paracuellos1-10/+10
'cpc' and 'mc' nodes correspond with the MIPS 'Cluster Power Controller' and 'MIPS Common Device Memory Map' which are present in some MIPS related boards. There is already bindings documentation for these two located in: - Documentation/devicetree/bindings/power/mti,mips-cpc.yaml - Documentation/devicetree/bindings/bus/mti,mips-cdmm.yaml Hence, properly update compatible strings and align nodes with already mainlined bindings documentation. Also, move their definition to a proper place since both of them are not related with the palmbus at all. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Link: https://lore.kernel.org/r/20211002060706.30511-1-sergio.paracuellos@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: mt7621-pci: properly adjust base address for the IO windowSergio Paracuellos1-1/+1
The value to adjust in the bridge register RALINK_PCI_IOBASE must take into account the raw value from DT, not only the translated linux port number. As long as io_offset is zero, the two are the same, but if you were to use multiple host bridge in the system, or pick a different bus address in DT, you can have a nonzero io_offset. At this means to take into account the bus address which is used to calculate this offset, substracting it from the IO resource start address. Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Link: https://lore.kernel.org/r/20210925203224.10419-7-sergio.paracuellos@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05Revert "staging: mt7621-pci: set end limit for 'ioport_resource'"Sergio Paracuellos1-2/+0
This reverts commit 50fb34eca2944fd67493717c9fbda125336f1655. Since IO_SPACE_LIMIT is not really being changed there is no real need to adjust the ioport_resource end limit. Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Link: https://lore.kernel.org/r/20210925203224.10419-3-sergio.paracuellos@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: prevent array underflow in rtw_hal_update_ra_mask()Dan Carpenter1-1/+1
The problem is that "mac_id" is a u32 so this check for underflow does not work when "mac_id" is zero. In that situation, "mac_id - 1" is UINT_MAX instead of -1 so the condition is true. It leads to an array underflow on the next line. Fixes: 8cd574e6af54 ("staging: r8188eu: introduce new hal dir for RTL8188eu driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20210930122604.GB10068@kili Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: vc04_services: shut up out-of-range warningArnd Bergmann1-1/+1
The comparison against SIZE_MAX produces a harmless warning on 64-bit architectures: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:185:16: error: result of comparison of constant 419244183493398898 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (num_pages > (SIZE_MAX - sizeof(struct pagelist) - ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Shut up that warning by adding a cast to a longer type. Fixes: ca641bae6da9 ("staging: vc04_services: prevent integer overflow in create_pagelist()") Cc: stable <stable@vger.kernel.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20210927113702.3866843-1-arnd@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: core: remove duplicate condition checkSaurav Girepunje1-1/+0
Remove the same expression (!memcmp(pIE->data, BROADCOM_OUI2, 3)) on both the side of "||" . Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVme3xtnCHN/hOjS@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: hal: remove assignment to itselfSaurav Girepunje1-1/+0
Remove assignment of 'pHalData->TRxAntDivType' to itself. Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVmXJFSCCU3cvG6y@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: core: remove unused variable local variableSaurav Girepunje3-5/+3
Remove unused local variable macAddr. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVhpBWhNt7mwfNKU@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: core: remove unused variable pAdapterSaurav Girepunje1-5/+3
Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent. Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YViKDzqX5isFX+gv@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: Use kmemdup() to replace kmalloc + memcpyKai Song1-2/+1
fix memdup.cocci warning: drivers/staging/r8188eu/os_dep/ioctl_linux.c:4452:33-40: WARNING opportunity for kmemdup Generated by: scripts/coccinelle/api/memdup.cocci Signed-off-by: Kai Song <songkai01@inspur.com> Link: https://lore.kernel.org/r/20211003072841.215903-1-songkai01@inspur.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: core: remove power_saving_wk_hdl functionSaurav Girepunje1-6/+1
Remove function power_saving_wk_hdl is it just calling rtw_ps_processor. Instead of power_saving_wk_hdl() call rtw_ps_processor(). Acked-by: Michael Straube <straube.linux@gmail.com> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVhv5JiHovfdpNGg@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform()Michael Straube3-20/+1
Function rtl8188e_silentreset_for_specific_platform() is empty. Remove it and remove code that does nothing other than using the unwanted DBG_88E macro now. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210930175546.11175-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: rtl8712: Statements should start on a tabstopDawid Esterhuizen1-5/+5
This path fixes four checkpatch.pl warnings: Statements should start on a tabstop Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com> Link: https://lore.kernel.org/r/YVXGsMZDGmdGjErJ@kkobus.whirley.local Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove inirp_deinit from struct hal_opsMichael Straube4-22/+1
Remove inirp_deinit from struct hal_ops and remove the wrappers rtw_hal_inirp_deinit() and rtl8188eu_inirp_deinit(). Call rtw_read_port_cancel() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210929192657.9569-8-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove inirp_init from struct hal_opsMichael Straube4-16/+4
Remove inirp_init from struct hal_ops and remove its wrapper rtw_hal_inirp_init(). Call rtl8188eu_inirp_init() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210929192657.9569-7-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove free_recv_priv from struct hal_opsMichael Straube4-13/+1
Remove free_recv_priv from struct hal_ops and remove its wrapper rtw_hal_free_recv_priv(). Call rtl8188eu_free_recv_priv() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210929192657.9569-6-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove init_recv_priv from struct hal_opsMichael Straube4-12/+2
Remove init_recv_priv from struct hal_ops and remove its wrapper rtw_hal_init_recv_priv(). Call rtl8188eu_init_recv_priv() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210929192657.9569-5-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove init_xmit_priv from struct hal_opsMichael Straube4-14/+1
Remove init_xmit_priv from struct hal_ops an remove its wrapper rtw_hal_init_xmit_priv(). Call rtl8188eu_init_xmit_priv() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210929192657.9569-4-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove GetHalDefVarHandler from struct hal_opsMichael Straube8-41/+18
Remove GetHalDefVarHandler from struct hal_ops and remove its wrapper rtw_hal_get_def_var(). Call GetHalDefVar8188EUsb() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210929192657.9569-3-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove SetHalDefVarHandler from struct hal_opsMichael Straube4-22/+7
Remove SetHalDefVarHandler from struct hal_ops and remove its wrapper rtw_hal_set_def_var(). Call SetHalDefVar8188EUsb() directly instead. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210929192657.9569-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove odm_GlobalAdapterCheck()Michael Straube2-7/+0
Function odm_GlobalAdapterCheck() is empty, remove it. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210928131930.8866-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: remove odm_DynamicBBPowerSaving()Michael Straube2-56/+0
SupportICType is ODM_RTL8188E in this driver. So function odm_DynamicBBPowerSaving() does nothing, remove it. It is the only user of odm_1R_CCA(), remove that function as well. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210928131930.8866-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: rtl8192u: remove unused static variableSaurav Girepunje1-3/+0
remove unused static variable channels. Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVjN9FT4KjLGX/Zg@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: rtl8192e: remove unused variable ieeeSaurav Girepunje1-5/+4
Remove unused local variable ieee from ActivateBAEntry(). Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVmAhOSRB8yc/iwU@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: r8188eu: Replace zero-length array with flexible-array memberGustavo A. R. Silva2-2/+2
One-element and zero-length arrays are deprecated and should be replaced with flexible-array members[1]. Replace zero-length array with flexible-array member and make use of the struct_size() helper in kmalloc(). [1] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Link: https://github.com/KSPP/linux/issues/160 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20210929193658.GA339070@embeddedor Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: rtl8723bs: core: remove reassignment of same value to variableSaurav Girepunje1-1/+0
Remove reassignment of same value to variable pstat->auth_seq. On if (seq == 1) assigning the value 2. At the end of if statement also assigning the value pstat->auth_seq = seq + 1 that is again assigning the value 2. Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVnX1HIYoisW621x@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: rtl8723bs: core: remove condition never executeSaurav Girepunje1-3/+0
Remove condition which never get execute. as pattrib->mdata is always zero before if condition check. Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVnTJCoz2qsXDXGc@user Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: rtl8723bs: Replace zero-length array with flexible-array memberGustavo A. R. Silva2-2/+2
One-element and zero-length arrays are deprecated and should be replaced with flexible-array members[1]. Replace zero-length array with flexible-array member and make use of the struct_size() helper. [1] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Link: https://github.com/KSPP/linux/issues/160 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20210929194118.GA340431@embeddedor Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: rtl8723bs: remove meaningless pstat->passoc_req check in OnAssocReq()Longji Guo1-6/+2
kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree is not necessary. Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Longji Guo <guolongji@uniontech.com> Link: https://lore.kernel.org/r/20210929110613.29979-1-guolongji@uniontech.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: vchiq_arm: move platform structs to vchiq_arm.cStefan Wahren2-39/+39
After merging vchiq_2835_arm.c into vchiq_arm.c some platform structs doesn't need to exported anymore. So move them into the C file. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1633264369-998-4-git-send-email-stefan.wahren@i2se.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: vchiq_arm: drop unnecessary declarationsStefan Wahren1-8/+0
vchiq_arm.h contains some unnecessary declarations, so drop them. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1633264369-998-3-git-send-email-stefan.wahren@i2se.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: vchiq_arm: re-order vchiq_arm_init_stateStefan Wahren2-21/+17
This moves vchiq_arm_init_state() above its caller, so we can drop the now unnecessary forward declaration and make the function static. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1633264369-998-2-git-send-email-stefan.wahren@i2se.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05staging: vt6655: fix camelcase in pbyCxtBufTommaso Merciai1-2/+2
Replace camel case variable name for variable pbyCxtBuf with snake case equivalent, in mac.h Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211001202504.410383-1-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-05media: hantro: Auto generate the AXI ID to avoid conflictsBenjamin Gaignard3-2/+5
The AXI ID is an AXI bus configuration for improve bus performance. If read and write operations use different IDs the operations can be paralleled, whereas when they have the same ID the operations will be serialized. Right now, the write ID is fixed to 0 but we can set it to 0xff to get auto generated IDs to avoid possible conflicts. This change has no functional changes, but seems reasonable to let the hardware to autogenerate the ID instead of hardcoding in software. Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-05media: hantro: Constify static struct v4l2_m2m_opsRikard Falkeborn1-1/+1
The only usage of vpu_m2m_ops is to pass its address to v4l2_m2m_init() which has a pointer to const struct v4l2_m2m_ops as argument. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-05media: imx: drop unneeded MODULE_ALIASKrzysztof Kozlowski1-1/+0
The MODULE_DEVICE_TABLE already creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-10-05media: cedrus: add check for H264 and H265 limitationsJernej Skrabec1-0/+46
Cedrus supports only YUV420 H264/H265 content and mostly only 8-bit colours (except on H6, where 10-bit are also supported). Add validation callback to SPS controls, which will reject unsupported combinations. Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Copyright © 1996 – 2026 Jason A. Donenfeld. All Rights Reverse Engineered.