From 25d950714781f34e7ae1292f38889cf39983cb38 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Fri, 22 Oct 2010 08:30:26 +0800 Subject: mfd: Remove unneeded ret value checking for max8998 register updates i2c_smbus_write_byte_data() returns zero or negative value, therefore no need to check if ret is greater than zero or not. Signed-off-by: Axel Lin Signed-off-by: Samuel Ortiz --- drivers/mfd/max8998.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c index a720f412cd15..06ddf741d4c7 100644 --- a/drivers/mfd/max8998.c +++ b/drivers/mfd/max8998.c @@ -110,8 +110,6 @@ int max8998_update_reg(struct i2c_client *i2c, u8 reg, u8 val, u8 mask) u8 old_val = ret & 0xff; u8 new_val = (val & mask) | (old_val & (~mask)); ret = i2c_smbus_write_byte_data(i2c, reg, new_val); - if (ret >= 0) - ret = 0; } mutex_unlock(&max8998->iolock); return ret; -- cgit v1.2.3-59-g8ed1b