From 50e356686fa9304f7cdc30b1fe696bde8afa79d6 Mon Sep 17 00:00:00 2001 From: Doug Berger Date: Sat, 25 Sep 2021 20:21:11 -0700 Subject: net: bcmgenet: remove netif_carrier_off from adjust_link The bcmgenet_mii_setup() function is registered as the adjust_link callback from the phylib for the GENET driver. The phylib always sets the netif_carrier according to phydev->link prior to invoking the adjust_link callback, so there is no need to repeat that in the link down case within the network driver. Signed-off-by: Doug Berger Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index ff1efd52ce16..8a9d8ceaa5bf 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -106,9 +106,6 @@ void bcmgenet_mii_setup(struct net_device *dev) /* done if nothing has changed */ if (!status_changed) return; - - /* needed for MoCA fixed PHY to reflect correct link status */ - netif_carrier_off(dev); } phy_print_status(phydev); -- cgit v1.2.3-59-g8ed1b