From fd5ebbc75ccba3487524fb03e784fa598b214d72 Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Tue, 19 Dec 2017 12:10:42 -0800 Subject: netdevsim: declare struct device_type as static struct device_type nsim_dev_type created for SR-IOV support should be static. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: David S. Miller --- drivers/net/netdevsim/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c index eb8c679fca9f..92678f55ee80 100644 --- a/drivers/net/netdevsim/netdev.c +++ b/drivers/net/netdevsim/netdev.c @@ -139,7 +139,7 @@ static void nsim_dev_release(struct device *dev) free_netdev(ns->netdev); } -struct device_type nsim_dev_type = { +static struct device_type nsim_dev_type = { .groups = nsim_dev_attr_groups, .release = nsim_dev_release, }; -- cgit v1.2.3-59-g8ed1b From 40946e93b32eb923b9d968557e44725aa6cb201a Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Tue, 19 Dec 2017 12:10:43 -0800 Subject: netdevsim: bpf: remove unused variable skip_sw is set but no longer used. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: David S. Miller --- drivers/net/netdevsim/bpf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/netdevsim/bpf.c b/drivers/net/netdevsim/bpf.c index 078d2c37a6c1..7799942ed349 100644 --- a/drivers/net/netdevsim/bpf.c +++ b/drivers/net/netdevsim/bpf.c @@ -107,7 +107,6 @@ int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type, struct tc_cls_bpf_offload *cls_bpf = type_data; struct bpf_prog *prog = cls_bpf->prog; struct netdevsim *ns = cb_priv; - bool skip_sw; if (type != TC_SETUP_CLSBPF || !tc_can_offload(ns->netdev) || @@ -115,8 +114,6 @@ int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type, cls_bpf->common.chain_index) return -EOPNOTSUPP; - skip_sw = cls_bpf->gen_flags & TCA_CLS_FLAGS_SKIP_SW; - if (nsim_xdp_offload_active(ns)) return -EBUSY; -- cgit v1.2.3-59-g8ed1b