From e6ac89fabd030704eac691dab7783ebe06e6b2c1 Mon Sep 17 00:00:00 2001 From: Jason Wessel Date: Thu, 5 Jan 2012 16:46:30 -0600 Subject: kbuild: Correctly deal with make options which contain an "s" When using remake, which is based on gnumake, if you invoke an example build as shown below, the build will become silent due to the top level make file incorrectly guessing that the end user wants a silent build because an argument that contained an "s" was used. Here are two examples one with remake and one with straight gnumake. remake --no-extended-errors make --warn-undefined-variables Fix up the top level Makefile to use filter to parse the options that mean silent instead of findstring catching other random arguments containing an "s". Signed-off-by: Jason Wessel CC: Michal Marek CC: Andrew Morton CC: linux-kbuild@vger.kernel.org Signed-off-by: Michal Marek --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Makefile') diff --git a/Makefile b/Makefile index 2e78b0800334..a9c1a3b7f1ee 100644 --- a/Makefile +++ b/Makefile @@ -312,7 +312,7 @@ endif # If the user is running make -s (silent mode), suppress echoing of # commands -ifneq ($(findstring s,$(MAKEFLAGS)),) +ifneq ($(filter s% -s%,$(MAKEFLAGS)),) quiet=silent_ endif -- cgit v1.2.3-59-g8ed1b