From 97a32864e6de5944c6356049f60569de01e9ba1f Mon Sep 17 00:00:00 2001 From: Sebastian Andrzej Siewior Date: Fri, 23 Sep 2016 15:02:38 +0200 Subject: blk-mq: fixup "Convert to new hotplug state machine" The "blk_mq_queue_reinit_dead()" just cleared the cpumask instead doing a copy. Since we might never had an online callback we could end up with a ZERO mask which in turn leads to crash as test robot demonstarted. Fixes: 65d5291eee66 ("blk-mq: Convert to new hotplug state machine") Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Jens Axboe --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'block/blk-mq.c') diff --git a/block/blk-mq.c b/block/blk-mq.c index 65347cb7d7e1..8c0f80198e52 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2158,7 +2158,7 @@ static void blk_mq_queue_reinit_work(void) static int blk_mq_queue_reinit_dead(unsigned int cpu) { - cpumask_clear_cpu(cpu, &cpuhp_online_new); + cpumask_copy(&cpuhp_online_new, cpu_online_mask); blk_mq_queue_reinit_work(); return 0; } -- cgit v1.2.3-59-g8ed1b