From 7efe20cf11655e860ae2852ebefebff244ddabb6 Mon Sep 17 00:00:00 2001 From: Thierry Reding Date: Tue, 15 Aug 2017 15:41:08 +0200 Subject: drm/tegra: hdmi: Use unsigned int for register offsets Register offsets are usually fairly small numbers, so an unsigned int is more than enough to represent them. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/gpu/drm/tegra/hdmi.c') diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index cda0491ed6bf..9161adaf94c1 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -100,13 +100,13 @@ enum { }; static inline u32 tegra_hdmi_readl(struct tegra_hdmi *hdmi, - unsigned long offset) + unsigned int offset) { return readl(hdmi->regs + (offset << 2)); } static inline void tegra_hdmi_writel(struct tegra_hdmi *hdmi, u32 value, - unsigned long offset) + unsigned int offset) { writel(value, hdmi->regs + (offset << 2)); } -- cgit v1.2.3-59-g8ed1b From 07a8aab89927ee58100b9a0d121dafacbcc3a5dd Mon Sep 17 00:00:00 2001 From: Thierry Reding Date: Tue, 15 Aug 2017 15:41:11 +0200 Subject: drm/tegra: hdmi: Trace register accesses Add tracepoint events for HDMI controller register accesses. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/hdmi.c | 8 +++++++- drivers/gpu/drm/tegra/trace.h | 7 +++++++ 2 files changed, 14 insertions(+), 1 deletion(-) (limited to 'drivers/gpu/drm/tegra/hdmi.c') diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 9161adaf94c1..cf9f69fc12e6 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -24,6 +24,7 @@ #include "hdmi.h" #include "drm.h" #include "dc.h" +#include "trace.h" #define HDMI_ELD_BUFFER_SIZE 96 @@ -102,12 +103,17 @@ enum { static inline u32 tegra_hdmi_readl(struct tegra_hdmi *hdmi, unsigned int offset) { - return readl(hdmi->regs + (offset << 2)); + u32 value = readl(hdmi->regs + (offset << 2)); + + trace_hdmi_readl(hdmi->dev, offset, value); + + return value; } static inline void tegra_hdmi_writel(struct tegra_hdmi *hdmi, u32 value, unsigned int offset) { + trace_hdmi_writel(hdmi->dev, offset, value); writel(value, hdmi->regs + (offset << 2)); } diff --git a/drivers/gpu/drm/tegra/trace.h b/drivers/gpu/drm/tegra/trace.h index b32d90c967e8..e5c2e431c101 100644 --- a/drivers/gpu/drm/tegra/trace.h +++ b/drivers/gpu/drm/tegra/trace.h @@ -31,6 +31,13 @@ DEFINE_EVENT(register_access, dc_readl, TP_PROTO(struct device *dev, unsigned int offset, u32 value), TP_ARGS(dev, offset, value)); +DEFINE_EVENT(register_access, hdmi_writel, + TP_PROTO(struct device *dev, unsigned int offset, u32 value), + TP_ARGS(dev, offset, value)); +DEFINE_EVENT(register_access, hdmi_readl, + TP_PROTO(struct device *dev, unsigned int offset, u32 value), + TP_ARGS(dev, offset, value)); + #endif /* DRM_TEGRA_TRACE_H */ /* This part must be outside protection */ -- cgit v1.2.3-59-g8ed1b