From 14ce82e536455ace3d6ca70f77bbc2c6b25b8268 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Sun, 7 Oct 2012 09:05:36 -0700 Subject: leds: lm355x: Return proper error for lm3556_indicator_pattern_store error path Signed-off-by: Axel Lin Acked-by: G.Shark Jeong Signed-off-by: Bryan Wu --- drivers/leds/leds-lm355x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/leds/leds-lm355x.c') diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c index 065ec015d67a..8f4e8e21ddb5 100644 --- a/drivers/leds/leds-lm355x.c +++ b/drivers/leds/leds-lm355x.c @@ -408,7 +408,7 @@ static ssize_t lm3556_indicator_pattern_store(struct device *dev, return size; out: dev_err(chip->dev, "%s:i2c access fail to register\n", __func__); - return size; + return ret; } static DEVICE_ATTR(pattern, 0666, NULL, lm3556_indicator_pattern_store); -- cgit v1.2.3-59-g8ed1b From 5bbf150cca196cb973e14d0a80508ba7f588dfd1 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Mon, 29 Oct 2012 01:40:21 -0700 Subject: leds: lm355x: Fix up world writable sysfs file We don't need the sysfs file to be world writable or group writable. This file is write-only, change it to S_IWUSR (0200). Signed-off-by: Axel Lin Acked-by: G.Shark Jeong Signed-off-by: Bryan Wu --- drivers/leds/leds-lm355x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/leds/leds-lm355x.c') diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c index 8f4e8e21ddb5..6bc029255e5b 100644 --- a/drivers/leds/leds-lm355x.c +++ b/drivers/leds/leds-lm355x.c @@ -411,7 +411,7 @@ out: return ret; } -static DEVICE_ATTR(pattern, 0666, NULL, lm3556_indicator_pattern_store); +static DEVICE_ATTR(pattern, S_IWUSR, NULL, lm3556_indicator_pattern_store); static const struct regmap_config lm355x_regmap = { .reg_bits = 8, -- cgit v1.2.3-59-g8ed1b