From 43926c2761bcf3a7a720f707510f9c00b2830bfa Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Tue, 22 May 2018 11:45:56 +0000 Subject: leds: sc27xx: Fix return value check in sc27xx_led_probe() In case of error, the function dev_get_regmap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: e081c49e30ec ("leds: Add Spreadtrum SC27xx breathing light controller driver") Signed-off-by: Wei Yongjun Signed-off-by: Jacek Anaszewski --- drivers/leds/leds-sc27xx-bltc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/leds') diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 54a90c8781b6..9d9b7aab843f 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -176,8 +176,8 @@ static int sc27xx_led_probe(struct platform_device *pdev) mutex_init(&priv->lock); priv->base = base; priv->regmap = dev_get_regmap(dev->parent, NULL); - if (IS_ERR(priv->regmap)) { - err = PTR_ERR(priv->regmap); + if (!priv->regmap) { + err = -ENODEV; dev_err(dev, "failed to get regmap: %d\n", err); return err; } -- cgit v1.2.3-59-g8ed1b