From 9f971573d96fc55efe9d48ff2ca160c9b95fbe37 Mon Sep 17 00:00:00 2001 From: Vladimir Oltean Date: Fri, 28 Jun 2019 00:46:37 +0300 Subject: net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK We need a better way to signal this, perhaps in phylink_validate, but for now just print this error message as guidance for other people looking at this driver's code while trying to rework PHYLINK. Cc: Russell King Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller --- drivers/net/dsa/sja1105/sja1105_main.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'drivers/net/dsa/sja1105') diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index b366b8e100f8..32bf3a7cc3b6 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -806,6 +806,11 @@ static void sja1105_mac_config(struct dsa_switch *ds, int port, if (sja1105_phy_mode_mismatch(priv, port, state->interface)) return; + if (link_an_mode == MLO_AN_INBAND) { + dev_err(ds->dev, "In-band AN not supported!\n"); + return; + } + sja1105_adjust_port_config(priv, port, state->speed); } -- cgit v1.2.3-59-g8ed1b