From d2ff4fa575000058def5f5c602784e233211d4e7 Mon Sep 17 00:00:00 2001 From: Saeed Mahameed Date: Wed, 7 Feb 2018 20:48:43 -0800 Subject: net/mlx5: Add missing likely/unlikely hints to cq events If a hardware event is targeting a CQ, that CQ should exist. Add unlikely to error handling flows. Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman --- drivers/net/ethernet/mellanox/mlx5/core/cq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'drivers/net/ethernet/mellanox/mlx5/core/cq.c') diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cq.c b/drivers/net/ethernet/mellanox/mlx5/core/cq.c index dfbeeaa43276..9feeb555e937 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cq.c @@ -97,7 +97,7 @@ void mlx5_cq_completion(struct mlx5_eq *eq, u32 cqn) refcount_inc(&cq->refcount); spin_unlock(&table->lock); - if (!cq) { + if (unlikely(!cq)) { mlx5_core_warn(eq->dev, "Completion event for bogus CQ 0x%x\n", cqn); return; } @@ -118,12 +118,12 @@ void mlx5_cq_event(struct mlx5_eq *eq, u32 cqn, int event_type) spin_lock(&table->lock); cq = radix_tree_lookup(&table->tree, cqn); - if (cq) + if (likely(cq)) refcount_inc(&cq->refcount); spin_unlock(&table->lock); - if (!cq) { + if (unlikely(!cq)) { mlx5_core_warn(eq->dev, "Async event for bogus CQ 0x%x\n", cqn); return; } -- cgit v1.2.3-59-g8ed1b