From 68511b48bfbe8ebce9c1a55f2ea656b0144f046c Mon Sep 17 00:00:00 2001 From: Roi Dayan Date: Mon, 3 Jan 2022 10:57:01 +0200 Subject: net/mlx5e: TC, Remove redundant error logging Remove redundant and trivial error logging when trying to offload mirred device with unsupported devices. Using OVS could hit those a lot and the errors are still logged in extack. Signed-off-by: Roi Dayan Reviewed-by: Maor Dickman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c | 8 -------- 1 file changed, 8 deletions(-) (limited to 'drivers/net/ethernet/mellanox/mlx5/core/en') diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c index a0832b86016c..c614fc7fdc9c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c @@ -45,14 +45,10 @@ verify_uplink_forwarding(struct mlx5e_priv *priv, termination_table_raw_traffic)) { NL_SET_ERR_MSG_MOD(extack, "devices are both uplink, can't offload forwarding"); - pr_err("devices %s %s are both uplink, can't offload forwarding\n", - priv->netdev->name, out_dev->name); return -EOPNOTSUPP; } else if (out_dev != rep_priv->netdev) { NL_SET_ERR_MSG_MOD(extack, "devices are not the same uplink, can't offload forwarding"); - pr_err("devices %s %s are both uplink but not the same, can't offload forwarding\n", - priv->netdev->name, out_dev->name); return -EOPNOTSUPP; } return 0; @@ -160,10 +156,6 @@ tc_act_can_offload_mirred(struct mlx5e_tc_act_parse_state *parse_state, } NL_SET_ERR_MSG_MOD(extack, "devices are not on same switch HW, can't offload forwarding"); - netdev_warn(priv->netdev, - "devices %s %s not on same switch HW, can't offload forwarding\n", - netdev_name(priv->netdev), - out_dev->name); return false; } -- cgit v1.2.3-59-g8ed1b