From 1086ca3a63a3af6b8a722fff55da46f111bc40ee Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 13 Jun 2019 09:51:02 +0300 Subject: net: phy: sfp: clean up a condition The acpi_node_get_property_reference() doesn't return ACPI error codes, it just returns regular negative kernel error codes. This patch doesn't affect run time, it's just a clean up. Signed-off-by: Dan Carpenter Reviewed-by: Ruslan Babayev Signed-off-by: David S. Miller --- drivers/net/phy/sfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/net/phy/sfp.c') diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 97960d73b4ab..2d816aadea79 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev) int ret; ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args); - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) { + if (ret || !is_acpi_device_node(args.fwnode)) { dev_err(&pdev->dev, "missing 'i2c-bus' property\n"); return -ENODEV; } -- cgit v1.2.3-59-g8ed1b