From 882518debc8487147d618d5f26f4bb0bea1cc05b Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Mon, 30 Apr 2018 14:22:59 +0100 Subject: pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case. There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different checks against *arg. This looks like an unintentional missing break so add in the break. Detected by CoverityScan, CID#1468456, 1468459 ("Missing break in switch") Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver") Signed-off-by: Colin Ian King Acked-by: Manivannan Sadhasivam Signed-off-by: Linus Walleij --- drivers/pinctrl/actions/pinctrl-owl.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'drivers/pinctrl/actions') diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c index 928b40f71a3c..ee090697b1e9 100644 --- a/drivers/pinctrl/actions/pinctrl-owl.c +++ b/drivers/pinctrl/actions/pinctrl-owl.c @@ -406,6 +406,7 @@ static int owl_group_pinconf_arg2val(const struct owl_pingroup *g, default: return -EINVAL; } + break; case PIN_CONFIG_SLEW_RATE: if (*arg) *arg = OWL_PINCONF_SLEW_FAST; @@ -441,6 +442,7 @@ static int owl_group_pinconf_val2arg(const struct owl_pingroup *g, default: return -EINVAL; } + break; case PIN_CONFIG_SLEW_RATE: if (*arg) *arg = 1; -- cgit v1.2.3-59-g8ed1b